Fix issue 1459-Add Capture Fullpage Screenshot keyword#1948
Fix issue 1459-Add Capture Fullpage Screenshot keyword#1948certainly-param wants to merge 3 commits into
Conversation
Implements the fullpage screenshot functionality requested in issue robotframework#1459. The keyword captures the entire page content by temporarily resizing the browser window to show the full page height, taking the screenshot, and then restoring the original window size. Features: - Works with all existing screenshot options (EMBED, BASE64, custom filenames) - Supports {index} placeholder for unique filenames - Includes comprehensive unit and acceptance tests - Follows same patterns as existing screenshot keywords This is useful for capturing long pages that require scrolling to see all content, especially helpful for debugging test failures.
|
Ready for review - Implements fullpage screenshot functionality as requested in issue #1459. All tests passing, ready for maintainer review. Thanks! |
|
@certainly-param What happens when the screen size is limited to less than the full page size? Will this still capture the full size or not? I could see there being some issues here with limited screen sizes. |
…tive support - Add Chrome DevTools Protocol (CDP) method for Chrome/Edge browsers Works in both headless and non-headless mode without screen size limits - Add Firefox native full-page screenshot support - Implement browser detection and capability checking - Use strategy pattern with automatic fallback to window resize method - Window resize method validates actual dimensions and warns on limitations - Update documentation to describe the three screenshot strategies - Resolves screen size limitation concerns in non-headless mode
764e474 to
ed5bf0e
Compare
|
We need this fix ! what's missing to approve/resolve ? |
|
I would vote against this feature and would close the PR.
As a workaround, if you need this feature you can copy/paste the code and make a plugin: https://github.com/robotframework/SeleniumLibrary/tree/master/docs/extending/plugin_api If you find it useful you can publish it as a Python package which everyone can use. As a general note, being polite pays of for a long way and understanding hurry is important. |
Fixes #1459
Implements the fullpage screenshot functionality requested in issue #1459.
The keyword captures the entire page content by temporarily resizing
the browser window to show the full page height, taking the screenshot,
and then restoring the original window size.
Features:
This is useful for capturing long pages that require scrolling to see
all content, especially helpful for debugging test failures.
Closes #1459