Repository navigation
Close the risks that matter before installing things3 - #1
Merged
Merged
Conversation
Disable the unauthenticated web server, keep the history key and task bodies out of ordinary logs, and refuse to reuse a saved history key for a different Things account. Short ids no longer resolve to the wrong object, reorder failures are reported, and delete moves a task to Trash instead of removing its history record. TLS crates are bumped to the patched versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This fork is the copy that will be built on the Omarchy box and on Grok Bot's VM. Upstream
mainstill has an unauthenticated command server, and a few write paths can hit the wrong object or the wrong account.GitHub Actions stay disabled on this fork, so merging does not publish a release.
What changed
things3 webserverrefuses to listen, andtiny_httpis gone. Grok Bot should run thethings3command directly.Debugand in HTTP error URLs. Commit bodies are logged only whenTHINGS3_LOG_COMMIT_BODY=1(the test wrapper sets that).deleteof a task sets Trash (tr: true) instead of history opt: 2. Area delete is still a real removal, because areas have no trash flag in this client.rustls0.23.45,rustls-webpki0.103.15,crossbeam-epoch0.9.21, andquinn-proto0.11.15.Tests
cargo test --all-targetsandcargo clippy --all-targets -- -D warningspassed on Rust 1.90.Not in this change
Upstream pull requests #1, #2, evanpurkhiser#5, and evanpurkhiser#11 are not merged. A new Things Cloud account avoids the legacy-id bugs. Do not point this CLI at the early-2010s account.