-
Notifications
You must be signed in to change notification settings - Fork 3
Fix: guard Owl feature-binding lookup so it fails safe on Linux #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/install-latest-installer
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| "use strict"; | ||
|
|
||
| const { | ||
| patchLinuxOwlFeatureGuard, | ||
| } = require("../../../../bootstrap.js"); | ||
|
|
||
| module.exports = { | ||
| id: "linux-owl-feature-guard", | ||
| phase: "extracted-app", | ||
| order: 130, | ||
| ciPolicy: "optional", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When an upstream bundle still references AGENTS.md reference: AGENTS.md:L198-L199 Useful? React with 👍 / 👎. |
||
| apply: patchLinuxOwlFeatureGuard, | ||
| }; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this discovered descriptor without updating
expectedIdsmakesnode --test scripts/patch-linux-window-ui.test.jsfail indefault core patch descriptors are grouped and unique, because the actual list now containslinux-owl-feature-guardwhile the expected list does not. This leaves the repository's documented patcher test suite—and the local core CI job that invokes it—failing for every run.AGENTS.md reference: AGENTS.md:L70-L71
Useful? React with 👍 / 👎.