Repository navigation
World: name 14 verified functions and match 4 helpers - #153
Merged
Merged
Conversation
roengstrom
requested changes
Oct 18, 2026
roengstrom
left a comment
roengstrom
left a comment
Owner
There was a problem hiding this comment.
Let's revert the renames of functions that are not yet decomped. I've tried verifying a few and they don't seem to do what their names imply. I suspect the names are still ai generated from inference, but we need to be strict and actually verify everything using a debugger.
johnbrett
force-pushed
the
world/149-1-types-v2
branch
from
October 20, 2026 20:52
27de7b1 to
9906bfc
Compare
roengstrom
reviewed
Oct 24, 2026
roengstrom
left a comment
roengstrom
left a comment
Owner
There was a problem hiding this comment.
Sorry for the late review, been a busy week. But looks good generally, just a couple of things that might be able to be improved?
Use a signed halfword for levelUpDisplayTimer so its negative sentinel needs no casts.
johnbrett
force-pushed
the
world/149-1-types-v2
branch
from
October 26, 2026 00:34
9906bfc to
20cb9cf
Compare
roengstrom
approved these changes
Oct 29, 2026
roengstrom
left a comment
roengstrom
left a comment
Owner
There was a problem hiding this comment.
It's good enough for merging, the requested cleanup can be done later I guess. Feels like a good idea to merge before it becomes stale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of splitting up #149.
Named after debugger tracing (each one confirmed running in the expected scenario):
func_800AE31C→InitActorsfunc_800B0EAC→DrawBankModelfunc_800B164C→InitPlayerPositionfunc_800B18B8→SyncSlotsToPlayerfunc_800B3FD4→SaveScenePlacementfunc_800B438C→RestoreScenePlacement(runs on return from battle)func_800B5ADC→GetFootprintCornersfunc_800B881C→ResetPositionHistoryfunc_800BD82C→RegisterSceneObjectfunc_800BFD10→DrawSkinnedModelfunc_800BFFEC→ResetWorldRenderStatefunc_800C0CA4→ClaimObjectSlotfunc_800C4AE4→TickStepCountersfunc_8009F594→TurnTowardAngleNewly matched:
TickStepCountersandfunc_800BBF0C, finishing the reference C that was in the commentsTurnTowardAnglefunc_800B97A0Verify: 368 matched, 0 mismatched.