Repository navigation
Decomp snd_voice - #191
Merged
Merged
Decomp snd_voice#191
Conversation
func_80014FFC writes all of a voice's SPU registers. func_800150A8 now takes the owning track's flags as a third argument, as its callers pass them, and the voice start and repeat addresses are unsigned.
func_800151C4, func_80015668 and func_80015AC8 step a track's slides and wave tables and work out its voice volume and pitch.
func_80015FE0 keys voices on for a set of tracks, and func_80016344 refreshes the voice table D_80073CB0 from the SPU envelopes. D_80073CB0 gets a placeholder struct.
func_800164D8 runs the voice update for the music and sound effect tracks, with func_80016478, func_80016A7C and func_80016C28. D_80074F10 and D_800772A4 are now shared through sound.h, and libspu.h gains the Psy-Q SpuSetNoiseClock prototype.
Report for SLUS_008.92 (829b3ed - 98b01fd)📈 Matched code: 68.13% (+0.46%, +6868 bytes) ✅ 10 new matches
|
dargor123
approved these changes
Oct 28, 2026
dargor123
left a comment
dargor123
left a comment
Collaborator
There was a problem hiding this comment.
approved (I saw a lot of >> operations, maybe they can be cleaned up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just dumping all the decomps I have locally to get it into the codebase. Will focus on cleaning it up later