Repository navigation
split menumain - #193
Merged
Merged
split menumain#193
Conversation
- splits into 3 TUs because of unaligned jumptables:
- menumain - begins at `func_801EF800`
- menumain2 - begins at `func_801F0274`
- menumain3 - begins at `func_801F776C`
- updated `menu.h` to reflect only menumain symbols used by external overlays
- updated all other submenu overlays to import `menu.h` instead of `menumain.h` (the last one is only imported by `menumain.c` and `menumain2.c`)
Eletonyy
approved these changes
Oct 29, 2026
roengstrom
requested changes
Oct 29, 2026
roengstrom
left a comment
roengstrom
left a comment
Owner
There was a problem hiding this comment.
Looks good, but maybe we can move the prototypes to the correct header files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
func_801EF800func_801F0274func_801F776Cmenu.hto reflect only menumain symbols used by external overlaysmenu.hinstead ofmenumain.h(the last one is only imported bymenumain.candmenumain2.c)