Repository navigation
Decomp snd_bank - #194
Merged
Merged
Decomp snd_bank#194
Conversation
Report for SLUS_008.92 (b9e5996 - b7c1caf)📈 Matched code: 69.35% (+0.64%, +9628 bytes) ✅ 30 new matches
|
func_8001A1E8_data moves from snd_param.c to sound.h with the fields snd_bank.c reads, and the music config's unk2C and unk30 point into the sequence data.
The sequence setup functions (func_8001708C, func_80017410, func_800174E4, func_80017DB0) and their helpers. sndBuildVoiceMask now takes the track array, and the sound command block's word is passed to func_8001708C as a pointer. Two loops count down because no ascending form matches, and func_80017AAC keeps a no-op continue for the match; comments say so.
Sound command handlers from the command table. func_80018908 keeps a do-while that does nothing at run time, and a loop that counts down because no ascending form matches; comments say both are needed for the match.
The rest of the sound command handlers in snd_bank.c.
roengstrom
force-pushed
the
sound-snd-bank
branch
from
October 29, 2026 21:47
7bb26a4 to
7034c36
Compare
dargor123
approved these changes
Oct 29, 2026
dargor123
left a comment
dargor123
left a comment
Collaborator
There was a problem hiding this comment.
I left a change request, but I approve since you said that will clean up later
| sndTrackApplyInstrument(track, 0); | ||
| } else { | ||
| if (tracks & bit) { | ||
| if (!(bit & mask)) { |
Collaborator
There was a problem hiding this comment.
these ifs could be combined into a single one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another big one, and again just getting it in so I can start the cleanup of the sound engine once it's all in