Skip to content

Link the shared effect library units into effect_022 - #196

Merged
roengstrom merged 2 commits into
mainfrom
split-effect_022-lib
Oct 30, 2026
Merged

roengstrom merged 2 commits into
mainfrom
split-effect_022-lib

Conversation

@roengstrom

Copy link
Copy Markdown
Owner

Most of effect22 is just shared library code that's statically linked into the binary so define the splits so it reuses already decomped library functions.

Bio carries common, rotz, aim, scatter, entity, emit_mode, tint and step. Its render object is a different revision and stays with Bio's own code.
@decomp-dev

decomp-dev Bot commented Oct 29, 2026

Copy link
Copy Markdown

Report for SLUS_008.92 (eca60c0 - 131b30a)

📈 Matched code: 68.84% (+0.95%, +14588 bytes)

✅ 69 new matches
Unit Item Bytes Before After
ovl/effect_022/lib/emit_mode effectEmitGouraudTexQuads +1120 0.00% 100.00%
ovl/effect_022/lib/emit_mode effectEmitTexQuads +1016 0.00% 100.00%
ovl/effect_022/lib/emit_mode effectEmitGouraudTexTris +980 0.00% 100.00%
ovl/effect_022/lib/emit_mode effectEmitGouraudQuads +928 0.00% 100.00%
ovl/effect_022/lib/emit_mode effectEmitTexTris +916 0.00% 100.00%
ovl/effect_022/lib/emit_mode effectEmitQuads +824 0.00% 100.00%
ovl/effect_022/lib/emit_mode effectEmitGouraudTris +808 0.00% 100.00%
ovl/effect_022/lib/emit_mode effectEmitTris +736 0.00% 100.00%
ovl/effect_022/lib/tint effectTintPlay +732 0.00% 100.00%
ovl/effect_022/lib/emit_mode effectEmitMesh +596 0.00% 100.00%
ovl/effect_022/lib/entity effectUpdateModelBounds +588 0.00% 100.00%
ovl/effect_022/lib/common effectMatrixRotX +400 0.00% 100.00%
ovl/effect_022/lib/common effectMatrixRotY +396 0.00% 100.00%
ovl/effect_022/lib/entity effectSpawnTask +396 0.00% 100.00%
ovl/effect_022/lib/rotz effectMatrixRotZ +396 0.00% 100.00%
ovl/effect_022/effect_022_entry func_801A0000 +388 0.00% 100.00%
ovl/effect_022/lib/common effectTextInit +336 0.00% 100.00%
ovl/effect_022/lib/entity effectCacheAnimSlotAnchors +316 0.00% 100.00%
ovl/effect_022/lib/entity effectCacheSlotAnchors +308 0.00% 100.00%
ovl/effect_022/lib/aim effectMatrixAim +268 0.00% 100.00%
ovl/effect_022/lib/scatter effectScatter +264 0.00% 100.00%
ovl/effect_022/lib/common effectDrawQuad128 +252 0.00% 100.00%
ovl/effect_022/lib/common effectDrawQuad256 +252 0.00% 100.00%
ovl/effect_022/lib/entity effectModelRandomY +184 0.00% 100.00%
ovl/effect_022/lib/common effectTextHex +172 0.00% 100.00%
ovl/effect_022/lib/entity effectModelRadius +164 0.00% 100.00%
ovl/effect_022/lib/aim effectMatrixLookAt +108 0.00% 100.00%
ovl/effect_022/lib/entity effectModelCentre +108 0.00% 100.00%
ovl/effect_022/lib/entity effectModelHalfWidth +88 0.00% 100.00%
ovl/effect_022/lib/entity effectModelCentreY +84 0.00% 100.00%

...and 39 more new matches

🥀 2 broken matches
Unit Item Bytes Before After
ovl/effect_022/effect_022 func_801A0000 -388 100.00% 0.00%
ovl/effect_022/effect_022 func_801A03A0 -8 100.00% 0.00%

@dargor123 dargor123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@roengstrom
roengstrom merged commit 8ae8c4d into main Oct 30, 2026
1 check passed
@roengstrom
roengstrom deleted the split-effect_022-lib branch October 30, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants