Skip to content

Disable monitoring on Windows (backport #250) - #252

Merged
fujitatomoya merged 1 commit into
lyricalfrom
mergify/bp/lyrical/pr-250
Aug 31, 2026
Merged

Disable monitoring on Windows (backport #250)#252
fujitatomoya merged 1 commit into
lyricalfrom
mergify/bp/lyrical/pr-250

Conversation

@mergify

@mergify mergify Bot commented Aug 20, 2026

Copy link
Copy Markdown

Description

Fixes #248
Disable RTI Monitoring on Windows
Update README.md to describe existing RTI_MONITORING2_ENABLE environment variable

Is this user-facing behavior change?

Yes, monitoring will now be disabled by default on Windows

Did you use Generative AI?

No

Additional Information
This is an automatic backport of pull request #250 done by Mergify.

@mergify mergify Bot mentioned this pull request Aug 20, 2026
@mergify

mergify Bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@fujitatomoya

Copy link
Copy Markdown
Collaborator

Pulls: #252
Gist: https://gist.githubusercontent.com/fujitatomoya/b703740f622e4cd5c08e780ee69a3827/raw/bf13d6831b8b1190a8b606ee0b13a1aac3c95827/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connextdds_common
TEST args: --packages-above rmw_connextdds_common
ROS Distro: lyrical
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20112

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fgallegosalido

Copy link
Copy Markdown
Collaborator

@fujitatomoya the Linux build failed at the start

@fujitatomoya

Copy link
Copy Markdown
Collaborator

Pulls: #252
Gist: https://gist.githubusercontent.com/fujitatomoya/2bf48e84f28a7c7341aa1bfce6eb7b1d/raw/bf13d6831b8b1190a8b606ee0b13a1aac3c95827/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connextdds_common
TEST args: --packages-above rmw_connextdds_common
ROS Distro: lyrical
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20158

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fgallegosalido

Copy link
Copy Markdown
Collaborator

@fujitatomoya the Linux test seems to not have run correctly. The Windows build failures, apart from two that we already know are flaky, the rest don't seem related to the Connext RMW.

@fujitatomoya

Copy link
Copy Markdown
Collaborator

Pulls: #252
Gist: https://gist.githubusercontent.com/fujitatomoya/9fec13bf915d1589552aff01bf17044a/raw/bf13d6831b8b1190a8b606ee0b13a1aac3c95827/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connextdds_common
TEST args: --packages-above rmw_connextdds_common
ROS Distro: lyrical
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20226

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fgallegosalido

Copy link
Copy Markdown
Collaborator

@fujitatomoya Windows and Linux test failures don't seem related to the Connext RMW. I think this is ready to be merged

@fujitatomoya
fujitatomoya merged commit 21d3bad into lyrical Aug 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants