Skip to content

Change private WithArgument methods to public - #603

Open
pcf0 wants to merge 1 commit into
rosenbjerg:mainfrom
pcf0:ExtensionPoints
Open

Change private WithArgument methods to public#603
pcf0 wants to merge 1 commit into
rosenbjerg:mainfrom
pcf0:ExtensionPoints

Conversation

@pcf0

@pcf0 pcf0 commented Nov 2, 2025

Copy link
Copy Markdown

FFMpegArgumentOptions.WithArgument is already public, which allows extensions.
However, this is not nice semantically, as the global arguments (e.g. -hide_banner, -nostats) have to be given as input arguments.

So I changed the other two methods of the classes FFMpegGlobalArguments and VideoFilterOptions from private to public to allow an extension here as well.
I have changed the name of the method FFMpegGlobalArguments.WithOption() to FFMpegGlobalArguments.WithArgument() so that it is consistent.

@codecov-commenter

codecov-commenter commented Nov 2, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.72%. Comparing base (5356536) to head (9f779a5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   71.72%   71.72%           
=======================================
  Files         123      123           
  Lines        3544     3544           
  Branches      311      311           
=======================================
  Hits         2542     2542           
  Misses        888      888           
  Partials      114      114           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pcf0 pcf0 mentioned this pull request Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants