Repository navigation
fix(ci): flaky TUI paging test + macos-14 runner retirement (red Test & build on main) - #15
Merged
Merged
Conversation
The TUI sorts sessions newest-first (since 0.12.0). The tui.test.tsx fixture stamped each record with its own `new Date()`, so when building the 80-record list crossed a millisecond tick, the later records sorted ahead of session-0 and `g` (jump to first) no longer showed it. Use one shared timestamp. resume.test.ts read the ambient AGENTCTL_CLAUDE_BIN, so it failed on any shell that exports an override. Stub it out for the default-bin test.
The macos-14 image is in scheduled brownouts before its retirement on 2026-11-02; jobs on it fail in ~1s during a brownout.
roypadina
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
Test & buildfailed on main (run 40913072530) attests/cli/tui.test.tsx→long lists > keeps the highlighted row inside the window while paging down: aftergthe frame showedsession-5at the top, notsession-0.Nothing in the merge differed from
feat/ai-find. The test is timing-dependent:sortRecords(…, 'used'); ties keep input order).rec()gave each record its ownnew Date(). When building the 80 records crossed a millisecond tick, the later records (session-5…79) outrankedsession-0…4, which then sorted to the end of the list.Reproduced deterministically by forcing a 1 ms gap after record 5: same failure, same frame.
A second cause appeared on this PR's first run:
Test & buildfailed in 1 s with "This job failed because of a scheduled macOS 14 runner image brownout. macOS 14 runner images will be retired on November 2, 2026" (actions/runner-images#13518). After 2026-11-02 every run onmacos-14would fail.Fix (tests + CI only, no shipped code)
tests/cli/tui.test.tsx: one shared timestamp for every fixture record..github/workflows/ci.yml:Test & buildruns onmacos-latestinstead ofmacos-14. The job name, and so the required check, is unchanged.tests/cli/resume.test.ts: the default-bin test read the ambientAGENTCTL_CLAUDE_BIN, so it failed on any shell that exports an override. It now stubs the variable out for that test.Local:
npm run typecheck,npm test(221/221) andnpm run buildpass; the TUI suite passed 5 runs in a row.No release: the change touches tests and CI only.
🤖 Generated with Claude Code