Repository navigation
2.10.1: fix Settings crash on secret params, unset kind condition - #16
Merged
Merged
Conversation
SecretStore.security() used Process.waitUntilExit(), which spins the main run loop. The SecureField binding getter calls it during a SwiftUI update, so the nested layout pass aborted in AttributeGraph (AG::Graph::value_set). Wait on a terminationHandler semaphore instead: blocks without re-entering the run loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The kind picker displays "URL" when no kind was saved, but evaluate() threw missingParam, so such a rule silently never matched and its actions never showed in the popup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
SecretStore.security()usedProcess.waitUntilExit(), which spins the main run loop; the SecureField binding getter runs it during a SwiftUI update, so the nested layout pass aborted in AttributeGraph (AG::Graph::value_set). It now waits on aterminationHandlersemaphore, which blocks without re-entering the run loop.evaluatethrewmissingParam, so the rule never matched and its actions never appeared in the popup. An unset kind now means URL.Release
Version 2.10.1 (build 81) + CHANGELOG entry.
Checks
build-for-testinggreen.securitycall a 1 ms main-run-loop timer fired 64 times with the old wait, 0 with the new one.🤖 Generated with Claude Code