Add bounded full-bag mapping gate - #102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
FullBagMappingStateadmission contract for source-bound bounded full-bag mapping.rosbag2_full_bag_mappingrunner with explicit source/episode/chunk limits, PointCloud2 chunk reassembly, registered clock correction, accepted root-to-sensor frame paths, full selected-stream ICP/pose graph, root-frame TSDF, embedded glTF receipt, and fail-closed JSON/HTML/manifest output.Acceptance evidence
The canonical bag matched SHA-256
b00d31e25dc0b53cba89cfbe16e5b118079c514a1d8c6f4089fac9c0e3ffd7c8. The no-artifact run intentionally exits 2 withmapping_admitted:falseand seven blockers because real source-bound calibration evidence is not present. A wrong-SHA probe also remains fail-closed, and Mission Cockpit propagates the mapping blockers.External receipts:
/media/sasaki/aiueo/spatialrust-results/v1-3/145k-full-bag-mapping-v3//media/sasaki/aiueo/spatialrust-results/v1-3/145k-full-bag-mapping-validation-probe-v1//media/sasaki/aiueo/spatialrust-results/v1-3/145k-mission-cockpit-v3/Checks
cargo fmt --all -- --checkcargo test --workspacecargo clippy --workspace --all-targets -- -D warningscargo test --workspace --all-features --no-runcargo clippy --workspace --all-features --lib -- -D warnings