perf(vision): accelerate class-aware batched NMS - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
spatialrust.batched_nmsNumPy API with contiguous borrowing and non-contiguous fallbacksdnn.NMSBoxesBatchedcomparison harness and register it in the benchmark manifestWhy
Class-aware NMS is a canonical object-detection post-processing step. The old Rust core preserved the correct semantics but scanned every globally kept detection and discarded unrelated classes inside the hot loop. Keeping a vector per class removes those comparisons without changing the global score-ordered result.
Measured impact
Windows 11, 6-core/12-thread Intel CPU, CPython 3.12.10, OpenCV 4.10, OpenCL off; seeded interleaved Python API medians:
Both profiles return exactly the same ordered kept indices. Another 32 randomized OpenCV parity cases also passed locally.
Validation
cargo test -p spatialrust-vision --features detectioncargo clippy -p spatialrust-vision --all-targets --features detection -- -D warningscargo clippy --manifest-path crates/spatialrust-py/Cargo.toml --all-targets -- -D warningsrustfmt --checkcargo doc -p spatialrust-vision --features detection --no-depsgit diff --check