perf(vision): accelerate Soft-NMS beyond OpenCV - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Soft-NMS is useful for crowded detections because it decays overlapping scores instead of removing every overlap. The existing implementation preserved the algorithm but repeatedly sorted and shifted the candidate vector, adding avoidable overhead.
Measured impact
On the documented Windows 11 / Intel 6-core test host, SpatialRust is 3.42x to 7.40x faster than OpenCV 4.10 across linear and Gaussian Soft-NMS workloads from 100 to 8,400 boxes. Selected indices match exactly; maximum updated-score error is 1.79e-7.
Validation
cargo test -p spatialrust-vision --features detection(8 passed)cargo clippy -p spatialrust-vision --all-targets --features detection -- -D warningscargo clippy --manifest-path crates/spatialrust-py/Cargo.toml --all-targets -- -D warningsrustfmt --checkcargo doc -p spatialrust-vision --features detection --no-depsWorkspace-wide rustfmt still reports the repository's pre-existing formatting baseline in unrelated files such as
stereo.rs; this slice does not modify those files.