perf(vision): accelerate rectangular morphology - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
u8rectangular morphologyWhy
The previous implementation scanned every active kernel sample for every output pixel, leaving 5×5 opening hundreds of times slower than OpenCV. Rectangles are separable, so the new path computes each line with block prefix/suffix extrema and bounded parallel row/column stages.
Measured impact
All published cases are bit-exact. The harness also passes 980 seeded randomized OpenCV comparisons across all seven operations.
Validation
cargo test -p spatialrust-vision --features imgproc-morphologycargo clippy -p spatialrust-vision --features imgproc-morphology -- -D warningscargo bench -p spatialrust-vision --bench morphology --features imgproc-morphology --no-runpython -m pytest crates/spatialrust-py/tests/test_bindings.py -q(68 passed, 1 skipped)python bench/opencv_morphology_comparison/performance.py --output target/opencv-morphology-performance.json