perf(vision): reuse morphology workspace - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
RectMorphologyWorkspaceand caller-owned*_intoAPIs for rectangular u8 morphologyMorphologyWorkspaceandout=with shape, contiguity, and overlap validationWhy
The accelerated rectangular engine still rebuilt scratch planes and worker buffers on every public call. Explicit workspace/output reuse removes recurring host allocation cost while preserving safe APIs, exact output, explicit ownership, and generic-shape fallbacks.
Impact
On the recorded 12-thread Windows host, caller-owned 511×511 opening is 3.25× faster than OpenCV at 1080p and 2.77× faster at 4K. OpenCV remains faster for 5×5 rectangles, which is documented as the current optimization boundary.
Validation
cargo test -p spatialrust-vision --features imgproc-morphology(14 passed)cargo clippy -p spatialrust-vision --features imgproc-morphology -- -D warnings