Skip to content

Extend tests of hywiki-display-referent-type #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matsl wants to merge 1 commit into
base: master
Choose a base branch
from
+29 −5
Open

Extend tests of hywiki-display-referent-type #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
2026-06-26 Mats Lidell <matsl@gnu.org>

* test/hywiki-tests.el (hywiki-display-hywiki-test): Add helper
display function.
(hywiki-tests--display-referent-type): Verify right display function
is called and hbut:current attributes are set.

2026-06-25 Bob Weiner <rsw@gnu.org>

* test/hywiki-tests.el (hywiki-tests--command): Fix interactive call
Expand Down
27 changes: 22 additions & 5 deletions test/hywiki-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
;; Author: Mats Lidell
;;
;; Orig-Date: 18-May-24 at 23:59:48
;; Last-Mod: 25-Jun-26 at 13:00:41 by Bob Weiner
;; Last-Mod: 26-Jun-26 at 00:03:34 by Mats Lidell
;;
;; SPDX-License-Identifier: GPL-3.0-or-later
;;
Expand Down Expand Up @@ -2071,11 +2071,28 @@ expected result."
(list #'hywiki-tags-view t nil bn)))
(should (= (line-number-at-pos) 3))))))

(defun hywiki-display-hywiki-test (wikiword value)
"Test helper for display-referent-type."
(format "%s:%s" wikiword value))

(ert-deftest hywiki-tests--display-referent-type ()
"Verify error case for `hywiki-display-referent-type'."
(with-temp-buffer
(let ((err (should-error (hywiki-display-referent-type "WikiWord" (cons 'unknown-type 'value)) :type 'error)))
(should (string-match-p "No hywiki-display function for referent type .unknown-type." (cadr err))))))
"Verify `hywiki-display-referent-type'.
See helper `hywiki-display-hywiki-test' above for verifying display call."
(hywiki-tests--preserve-hywiki-mode
(insert "WikiWord")
(goto-char 4)

(ert-info ("Error cases")
(let ((err (should-error (hywiki-display-referent-type "WikiWord" (cons "unknown-type" 'value)) :type 'error)))
(should (string-match-p "Referent type must be a symbol" (cadr err))))
(let ((err (should-error (hywiki-display-referent-type "WikiWord" (cons 'unknown-type 'value)) :type 'error)))
(should (string-match-p "No hywiki-display function for referent type .unknown-type." (cadr err)))))

(ert-info ("Display hywiki-test with Value")
(hattr:clear 'hbut:current)
(should (string= "WikiWord:Value" (hywiki-display-referent-type "WikiWord" (cons 'hywiki-test 'Value))))
(should (string= "hywiki-test" (hattr:get 'hbut:current 'referent-type)))
(should (equal 'Value (hattr:get 'hbut:current 'referent-value))))))

(ert-deftest hywiki-tests--create-referent ()
"Verify `hywiki-create-referent'."
Expand Down