Skip to content

Fix - Enforce activity ownership verification on media upload endpoint #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Intenzi merged 3 commits into from
Oct 13, 2026
+15 −4
Merged

Fix - Enforce activity ownership verification on media upload endpoint #2380

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
253add2
fix: enforce activity ownership check on media upload endpoint
Intenzi Oct 12, 2026
0aaba07
fix: strip unverified activity_id from upload object
Intenzi Oct 12, 2026
459a282
fix: require authenticated user for activity ownership check
Intenzi Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions app/main/controllers/upload/RTMediaUploadEndpoint.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,22 @@ public function template_redirect( $create_activity = true ) {
$model = new RTMediaUploadModel();
do_action( 'rtmedia_upload_set_post_object' );
$this->upload = $model->set_post_object();
unset( $this->upload['activity_id'] );

if ( -1 !== $_activity_id && ! empty( $_activity_id ) ) {
Comment thread
Intenzi marked this conversation as resolved.
$can_attach = false;
// Query the activity to check if the activity belongs to the user.
if ( is_user_logged_in() && function_exists( 'bp_activity_get_specific' ) ) {
$activity = bp_activity_get_specific( array( 'activity_ids' => array( intval( $_activity_id ) ) ) );
if ( ! empty( $activity['activities'][0] ) && intval( $activity['activities'][0]->user_id ) === get_current_user_id() ) {
$can_attach = true;
}
}

if ( -1 !== $_activity_id ) {
$this->upload['activity_id'] = $_activity_id;
$activity_id = $_activity_id;

if ( $can_attach ) {
$this->upload['activity_id'] = $_activity_id;
$activity_id = $_activity_id;
}
}

// Media uploaded into a group takes its privacy from that group.
Expand Down
Loading