Skip to content

Version update v4.7.16 - #2389

Merged
Pradeep1308 merged 5 commits into
masterfrom
develop
Oct 28, 2026
Merged

Pradeep1308 merged 5 commits into
masterfrom
develop

Conversation

@Intenzi

@Intenzi Intenzi commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Changelog

  • FIXED
    • Fixed GoDAM video player markup corruption in BuddyPress activity updates and comments caused by content filters.

Intenzi and others added 5 commits October 23, 2026 18:29
* fix(godam): protect activity player markup from content filters

The GoDAM player was expanded inline into BuddyPress activity content and
then run through make_clickable, the theme hashtag linkifier and wpautop.
Those filters turned the #hex colours and URLs inside the player's data-*
attributes into <a> tags, shattering the markup so Video.js got no source
and the video could not play.

Emit a neutral placeholder during normal filtering and swap in the real
[godam_video] output on a PHP_INT_MAX pass, after every other
bp_get_activity_content_body filter has run. Covers the activity-video and
activity-comment paths; surrounding activity text keeps its formatting.

Closes #2386

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(godam): expand comment-video placeholders on the comment pipeline

Activity comments render via bp_get_activity_content + bp_activity_comment_content
and never hit bp_get_activity_content_body, so comment-video placeholders were
left in the DOM as empty <div>s. Also register the expansion on
bp_activity_comment_content (PHP_INT_MAX) so comment videos expand too.

Addresses review feedback on #2387.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: KMchaudhary <kuldipkumar.chaudhary@rtcamp.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
@Intenzi
Intenzi requested a review from Pradeep1308 October 28, 2026 05:16
@rtBot

rtBot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Unable to PHPCS or SVG scan one or more files due to error running PHPCS/SVG scanner:

  • index.php
  • templates/media/godam-integration.php

The error may be temporary. If the error persists, please contact a human (commit-ID: 38a62ff).

@Intenzi Intenzi self-assigned this Oct 28, 2026
@Pradeep1308
Pradeep1308 merged commit 81a1c27 into master Oct 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants