Run bundle with the Ruby running the tests - #3099
Merged
Merged
Conversation
The `bundle` executable in `PATH` can belong to another Ruby installation. In ruby/ruby CI the tests run with a freshly built `ruby` whose `RUBYLIB` points at the build tree, so the `bundle` from the setup-ruby toolchain aborts with `ruby lib version (4.1.0) doesn't match executable version (3.1.7)`, failing `test_collection_install__nongem_stdlib_no_warning`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bundleexecutable found inPATHdoes not always belong to the Ruby running the tests. In ruby/ruby CI the suite runs with a freshly builtrubyand aRUBYLIBpointing at the build tree, so thebundlefrom the setup-ruby toolchain loads that tree'srbconfig.rband aborts withruby lib version (4.1.0) doesn't match executable version (3.1.7). That is whytest_collection_install__nongem_stdlib_no_warningfails there, and whytool/rbs_skip_testsin ruby/ruby keeps growing with entries forRBS::CliTest.Running
bundlethroughRbConfig.rubyremoves the mismatch. I reproduced the CI failure locally by putting another Ruby'sbundlefirst inPATHwhileRUBYLIBpointed at the running Ruby, and with this change all 21test_collection_*cases pass in that setup.