OpenSpace camera mode — PR 1: ground preparation - #830
Merged
Merged
Conversation
- world arm: a zoom nudge runs absoluteRung.step, frameAlignedRoll included, so a nudge cannot pop at the engage flip; rung-level parity test replaces the zoomedDistance restatement - body arm: settle orbit/look first, roll after; the forced 'strafe' mode is gone, so look+roll writes the tilt memory and orbit+roll keeps its level - PersistedValue.skip deleted: no reducer writes a null dismissedVersion - roll-sign and tween-ease tests assert outcomes (imagePlaneBasis up; the tween's own yaw fraction) instead of restating the formula - inline-type ratchet: drop the stale surfaceStep.ts entry
nudge signature and cells (SurfaceStepCtx, PITCH_LIMIT, zoom as the wheel step, roll after the settle), ControlScheme without bindAxis until PR 2, the PersistedValue table with splashStorage.ts kept, and lookOffset eased by the tween row while a clip snaps it.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
skymap | fca07f6 | Commit Preview URL Branch Preview URL |
Oct 04 2026, 07:31 AM |
DoD audit READY: 1422 test files / 14891 tests pass, typecheck clean, 28/28 checkboxes, no new TODO markers, user smoke attested. Spec stays in specs/ — PR 2 still implements its feature half. Ledger archived.
rulkens
marked this pull request as ready for review
October 4, 2026 07:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ground preparation for the OpenSpace camera control scheme (spec §3, plan). Nothing here changes behaviour; the skymap scheme drives exactly as before.
approachDoneargument.CONTROL_SCHEMESregistry.CameraPose.lookOffsetturns the view about the eye; at zero it is neutral.RungRow.nudgecolumn takes pixel-free motion on every arm.The feature itself (the navigator, its driver rows, settings and UI) follows in PR 2.
🤖 Generated with Claude Code