Repository navigation
fix(serialization): preserve slotted dataclass fields - #640
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
@dataclass(slots=True)instance has no__dict__. The generic dataclass branch inEventSerializerraisesAttributeErrorand silently replaces the complete value with a non-serializable placeholder, losing its fields in trace data. The existing LangGraph-specific branch avoids this for Command, but other slotted dataclasses still fail.Read declared fields with
dataclasses.fieldsandgetattr, including inherited slots. Preserve any existing instance dictionary entries to retain support for dynamic attributes on ordinary dataclasses, and continue recursively serializing field values through the existing serializer.Add 16 cases through
serialize_to_strandjson.dumps(..., cls=EventSerializer): inherited dataclasses, slots/ordinary storage, frozen/mutable values, nested/direct payloads, and UUID field values. Tests follow the repository's Given/When/Then convention.Validation on Python 3.13:
--noconftest -o addopts=''to isolate the serialization module from unrelated integration fixtures.admin_api_keyattribute; those pass with the locked version.No generated resources, live API calls, or customer data. Full framework/integration suite was not run.