Repository navigation
Encode the B-frame end_time test clip with explicit B-frames - #21
Merged
Merged
Conversation
test_decode_end_time_with_b_frames relied on libx264's default GOP having B-frames. Add a b_frames option to TestVideoParameters (-bf N, plus b-adapt=0 for libx264 so the pattern is fixed rather than adaptive) and request 3 B-frames in that test, so it keeps exercising out-of-order packets if encoder defaults change.
|
| Commit | Scanned at | New | Resolved | Net |
|---|---|---|---|---|
3d7974d < |
2026-10-04 22:22 UTC | 0 | 0 | 0 |
Last scanned: 3d7974d · 2026-10-04 22:22 UTC
|
| Commit | Scanned at | New | Resolved | Net |
|---|---|---|---|---|
3d7974d < |
2026-10-04 22:22 UTC | 0 | 0 | 0 |
Last scanned: 3d7974d · 2026-10-04 22:22 UTC
ksindi
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #19:
test_decode_end_time_with_b_framesrelied on libx264's default GOP containing B-frames.TestVideoParametersgets ab_frames: Option<u32>(defaultNone, so other tests are unchanged). It passes-bf N, and for libx264 alsob-adapt=0, since-bfonly caps the B-frame run and adaptive placement can still pick fewer.end_timetest requests 3 B-frames.Checked with ffprobe on the test clip (FFmpeg 7.1.1): explicit flags give 111 B / 38 P / 1 I frames, the same as today's default;
-bf 0gives 0 B.cargo test: 95 passed, 3 ignored.