Repository navigation
fix(polling): stop synchronous waits on cancelled tasks - #286
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronous
wait_for_task_output()ignores a task's terminalCANCELLEDstatus and keeps polling until timeout, although its documented behavior is to raiseTaskFailedErrorwhen a task fails or is cancelled. Both synchronous implementations have this gap: the creation-response factory and the method injected into retrieved tasks. Their async counterparts already handle cancellation.Add
CANCELLEDto the two synchronous failure checks, matching existing async behavior.Validation: 12 new cases use the public sync/async clients with local HTTPX MockTransport responses through
generate.image.create(...).wait_for_task_output()andtasks.retrieve(...).wait_for_task_output(). They cover CANCELLED/FAILED/SUCCEEDED and reject any extra request after the terminal response. Before: 2 failed, 10 passed. After: all 12 pass; the full non-API-resource suite reports 494 passed, 2 skipped. Generated API-resource tests needing a mock API server are excluded.Repository-wide Ruff lint, changed-file formatting, targeted mypy, and git diff --check pass. Poll sleeps are replaced with no-ops in tests. No live generation requests or paid Runway resources used.