Skip to content

Support for address / scriptPubKey descriptors, or expose the descriptor checksum helper #294

Description

@darosior

We use address descriptors downstream (because bitcoind doesn't support Miniscript descriptors yet), and we can't compute the address descriptor checksum without bitcoind short of copying the checksum code from here. (See revault/revaultd#364.)

If rust-miniscript had support for address or scriptPubKey descriptors this would also solve the issue as we could just leverage their Display implem. It would be a preferable route if we think the checksum computation should be considered internal.

Activity

  1. sanket1729 commented on Jan 17, 2023

    @sanket1729
    Member

    Can look into this once we begin the partial descriptors journey.

  2. sanket1729 commented on Jan 17, 2023

    @sanket1729
    Member

    Sorry for the year+ late response. The checksum function is fairly stable, we can make this public for other uses for checksum algorithm too.

  3. sanket1729 commented on Jan 17, 2023

    @sanket1729
    Member

    Made a PR to make checksum pub, keeping this open for more discussion.

    I am not sure if we (ever) want to support addr descriptors. cc @apoelstra

  4. apoelstra commented on Jan 18, 2023

    @apoelstra
    Member

    Making checksum pub sounds good to me. This may even be useful for elements-miniscript.

    +1 to revisiting the addr descriptor once we have partial descriptors. For now though we should not support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions