feat: Add from_hex_str methods to Color and RgbColor#332
Open
joshtriplett wants to merge 3 commits into
Open
Conversation
A color like `#abc` should be interpreted as equivalent to `#aabbcc`.
Converting from a 3-digit or 6-digit hex color is a common operation in various formats, including HTML/CSS, SVG, and Git. Add it to anstyle.
Collaborator
|
This is pushing further at the boundaries of The limited scope was for two reasons
The main impact I can see this having is more in the "well, you parse X, but what about Y". Beyond, the question is where do we draw the line? |
Contributor
Author
|
@epage I originally considered making this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting from a 3-digit or 6-digit hex color is a common operation in various formats, including HTML/CSS, SVG, and Git. Add it to anstyle.
I've based this PR on #331, which fixes a bug in this logic.