Skip to content

build queue: refactor & cache priority-finding for new releases - #3378

Merged
syphar merged 1 commit into
rust-lang:mainfrom
syphar:cached-priorities
Aug 11, 2026
Merged

build queue: refactor & cache priority-finding for new releases#3378
syphar merged 1 commit into
rust-lang:mainfrom
syphar:cached-priorities

Conversation

@syphar

@syphar syphar commented Jun 20, 2026

Copy link
Copy Markdown
Member

prep-work for the SQS ingestion from crates.io so we support a higher load in event ingestion without all these queries.

  • unifies the priority logic in one struct that is easily testable.
  • We still need a call (reevaluate_priorities) every now and then, which would update priorities of already queued releases, if the underlying data changes (patterns, workspace sizes, ...), but that's more optional.
  • While I was on it, I also added a builder to the FakeGithubStats struct and improved some code quality in tests.
  • There's a pending refactor / some duplications with test-environments, but I want to postpone that change.
  • I want to directly store regex in the pattern-based priorities later, but for now I want this PR to be easily revertible.

@syphar syphar self-assigned this Jun 20, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jun 20, 2026
@syphar
syphar force-pushed the cached-priorities branch 3 times, most recently from f519c43 to 54fbb41 Compare June 20, 2026 05:09
@syphar syphar changed the title WIP: cache crate priority overrides build queue: refactor & cache priority-finding for new releases Jun 20, 2026
@syphar
syphar marked this pull request as ready for review June 20, 2026 05:13
@syphar
syphar requested a review from a team as a code owner June 20, 2026 05:13
@syphar
syphar force-pushed the cached-priorities branch from 15607ca to 96f788a Compare June 20, 2026 06:25
@rustbot

This comment has been minimized.

@syphar
syphar marked this pull request as draft August 5, 2026 07:05
@syphar
syphar force-pushed the cached-priorities branch from 96f788a to d33a1e7 Compare August 5, 2026 07:42
@syphar
syphar marked this pull request as ready for review August 5, 2026 07:59
@syphar
syphar force-pushed the cached-priorities branch from d33a1e7 to b941287 Compare August 6, 2026 08:56
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@syphar
syphar force-pushed the cached-priorities branch from b941287 to 8d8459b Compare August 10, 2026 09:33
@rustbot

This comment has been minimized.

@syphar
syphar force-pushed the cached-priorities branch 3 times, most recently from c07ade6 to 4dbaa2b Compare August 10, 2026 13:50
@rustbot

This comment has been minimized.

@syphar
syphar force-pushed the cached-priorities branch from 65e13ed to c3393a1 Compare August 11, 2026 17:17
@rustbot

This comment has been minimized.

@syphar

syphar commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned syphar Aug 11, 2026
@GuillaumeGomez

Copy link
Copy Markdown
Member

Can you not include sqlx file changes in your PR please? The server regenerate them, and it would make the review much simpler for me without having all these file files to ignore. :')

@syphar

syphar commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

Can you not include sqlx file changes in your PR please? The server regenerate them, and it would make the review much simpler for me without having all these file files to ignore. :')

this will only work after merge, so CI on the PR will always be red? or am I missing something?

@syphar

syphar commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

but a valid point, let me think about a good solution. I could imagine one when we have the new infra, not sure with the current infra.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Isn't the CI regenerate them? Because I don't commit my sqlx changes anymore as they never work for some reason. ^^'

@syphar

syphar commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

Isn't the CI regenerate them? Because I don't commit my sqlx changes anymore as they never work for some reason. ^^'

not on PRs, as it looks like: #3443

#3442 might help a little

@GuillaumeGomez

Copy link
Copy Markdown
Member

Hum, maybe we should do that. Would simplify things a lot.

@rustbot

rustbot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@syphar
syphar force-pushed the cached-priorities branch from 62d5415 to 28856cb Compare August 11, 2026 20:54
@syphar

syphar commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

@GuillaumeGomez I rebased on main, and regenerated the sqlx files.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Looks good to me!

@syphar
syphar merged commit b67fb7d into rust-lang:main Aug 11, 2026
13 checks passed
@syphar
syphar deleted the cached-priorities branch August 11, 2026 21:03
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants