Skip to content

add retries to fastly api requests, use same retry logic for registry api - #3417

Merged
GuillaumeGomez merged 1 commit into
rust-lang:mainfrom
syphar:fastly-retry
Aug 10, 2026
Merged

add retries to fastly api requests, use same retry logic for registry api#3417
GuillaumeGomez merged 1 commit into
rust-lang:mainfrom
syphar:fastly-retry

Conversation

@syphar

@syphar syphar commented Jul 24, 2026

Copy link
Copy Markdown
Member

to fix errors like this sentry error

  • fastly api requests weren't retried before, we have some sentry errors where content was outdated because of that.
  • registry api retries where just retried for all possible errors. the reqwest-retry logic only retries transient errors, which would reduce load on crates.io.

With this middleware we get retries just for "transient" errors, and niceties like jittering.

When the repackage & #3414 is done we then can remove our custom retry_async method.

the default retry strategy is explained here:

@syphar syphar self-assigned this Jul 24, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jul 24, 2026
@syphar
syphar force-pushed the fastly-retry branch 3 times, most recently from cb1678e to 2a4dec6 Compare July 28, 2026 05:17
@syphar syphar changed the title WIP: add retries to fastly api requests, use same retry logic for registry api add retries to fastly api requests, use same retry logic for registry api Aug 5, 2026
@syphar
syphar marked this pull request as ready for review August 5, 2026 00:51
@syphar
syphar requested a review from a team as a code owner August 5, 2026 00:51
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

rustbot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@syphar

syphar commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned syphar Aug 10, 2026
@GuillaumeGomez

Copy link
Copy Markdown
Member

Looks good to me, thanks!

@GuillaumeGomez
GuillaumeGomez merged commit c65aa7f into rust-lang:main Aug 10, 2026
13 checks passed
@GuillaumeGomez
GuillaumeGomez deleted the fastly-retry branch August 10, 2026 09:39
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Aug 10, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants