fix rustdoc-json & coverage for proc-macro crates with custom rustc_args - #3440
Merged
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
force-pushed
the
fix-procmacro-json
branch
from
August 11, 2026 18:49
d68a99d to
b0d02a8
Compare
syphar
force-pushed
the
fix-procmacro-json
branch
from
August 11, 2026 18:51
b0d02a8 to
1698ec0
Compare
Member
Author
GuillaumeGomez
approved these changes
Aug 11, 2026
Member
|
Thanks! |
github-actions
Bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weird corner-case. I was digging into cases where we still don't get rustdoc-json for some crates.
In 3f92a79 we added
-Zhost-config,-Ztarget-applies-to-host, and--config host.rustflags={}to also pass customrustc_argsto build scripts. This works because we always pass--targetto doc builds.In case of proc-macro builds it's different: we don't pass
--target, so the args above lead to our custombuild.rustdocflagsconfig being ignored, including customrustdocflagsfrom the metadata, or--output-format jsonfrom us.This removes
target-applies-to-hostfor proc-macro crates.for now I wouldn't try to rebuild rustdoc-json, since it's super tricky to find the affected crates. This could be a part of a general backfill.