Skip to content

fix json / coverage builds with custom -Z rustdoc-scrape-examples given - #3441

Merged
GuillaumeGomez merged 1 commit into
rust-lang:mainfrom
syphar:fix-args-scrape
Aug 11, 2026
Merged

fix json / coverage builds with custom -Z rustdoc-scrape-examples given#3441
GuillaumeGomez merged 1 commit into
rust-lang:mainfrom
syphar:fix-args-scrape

Conversation

@syphar

@syphar syphar commented Aug 11, 2026

Copy link
Copy Markdown
Member

Fix errors like this.

Since #3438 we only pass -Z rustdoc-scrape-examples for HTML builds. But crates can use docs.rs metadata to add -Z rustdoc-scrape-examples themselves. This breaks the coverage & json builds for them.

@syphar syphar self-assigned this Aug 11, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Aug 11, 2026
syphar added a commit to syphar/docs.rs that referenced this pull request Aug 11, 2026
@syphar
syphar marked this pull request as ready for review August 11, 2026 20:07
@syphar
syphar requested a review from a team as a code owner August 11, 2026 20:07
@syphar

syphar commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned syphar Aug 11, 2026
@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@GuillaumeGomez
GuillaumeGomez merged commit c0e7904 into rust-lang:main Aug 11, 2026
17 of 20 checks passed
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Aug 11, 2026
@GuillaumeGomez
GuillaumeGomez deleted the fix-args-scrape branch August 11, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants