Derive Default for Level and LevelFilter enums - #736
Open
ssrlive wants to merge 1 commit into
Open
Conversation
Collaborator
|
I'm not sure about implementing default for the level, I imagine we might not be able to agree on what the default should be. Btw you can also implement |
Contributor
|
Thanks for the PR @ssrlive! I share the same reservations as @Thomasdezeeuw, and don’t believe we should implement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using log crate, we might sometimes define a struct with the
Defaultmacro,but if
LevelorLevelFilterdoesn't implement theDefaulttrait, this struct will fail to compile.Therefore, I created this PR. I hope you will approve it and merge it.