Skip to content

Perform ThinLTO on x86_64-pc-windows-msvc dist builder - #128947

Open
Zoxc wants to merge 2 commits into
rust-lang:mainfrom
Zoxc:thinlto-msvc
Open

Perform ThinLTO on x86_64-pc-windows-msvc dist builder#128947
Zoxc wants to merge 2 commits into
rust-lang:mainfrom
Zoxc:thinlto-msvc

Conversation

@Zoxc

@Zoxc Zoxc commented Aug 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

View all comments

This reenables ThinLTO on x86_64-pc-windows-msvc.

try-job: dist-x86_64-apple

@rustbot

rustbot commented Aug 10, 2024

Copy link
Copy Markdown
Collaborator

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 10, 2024
@jieyouxu

jieyouxu commented Aug 11, 2024

Copy link
Copy Markdown
Member

FYI @rust-lang/infra

@lqd

lqd commented Aug 11, 2024

Copy link
Copy Markdown
Member

I don't think we're in a situation where we can yet have a definite yes/no answer for this PR yet.

Marking as blocked on #122790. The discussions and underlying issues there shouldn't be split amongst PRs.

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2024
@Zoxc Zoxc mentioned this pull request Aug 11, 2024
Merged
@bors

bors commented Sep 20, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #130506) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc

Zoxc commented Mar 11, 2025

Copy link
Copy Markdown
Contributor Author

@rustbot ready

This is no longer blocked, at least not on my previous PR.

Are the binaries built by dist jobs properly tested now?
Are there any other knowns issues with ThinLTO on Windows?

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 11, 2025
@Kobzol

Kobzol commented Mar 11, 2025

Copy link
Copy Markdown
Member

They are tested, not sure if properly :) Last time we tried it, one test was still miscompiled, we could try again.

  • comment out DIST_TRY_BUILD insrc/ci/github-actions/jobs.yml
  • add a line try-job: dist-x86_64-msvc to the PR description
  • run a try build

@jieyouxu

jieyouxu commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

They are tested, not sure if properly :)

As far as I know, Windows dist artifacts are not tested at all (note that dist artifacts are not necessarily equivalent to test job artifacts; and usually they are not equivalent due to configuration differences). We do have Windows test jobs that run the full test suites but they aren't testing the dist artifacts.

EDIT: x86_64-pc-windows-msvc goes through opt-dist but not the other i686-pc-windows-msvc apparently.

Recently we broke i686-pc-windows-gnu rustc binaries in a way that caused rustc binary to completely not work (rustc -vV failed) but no tests caught it.

@lqd

lqd commented Mar 11, 2025

Copy link
Copy Markdown
Member

As far as I know, Windows dist artifacts are not tested at all

We do test dist x64 msvc artifacts in opt-dist.

@jieyouxu

jieyouxu commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Huh. I must be thinking of x86_64 windows-gnu or maybe the 32 bit windows-msvc target?

EDIT: in any case you're right:

https://github.com/rust-lang/rust/blob/master/src%2Fci%2Fgithub-actions%2Fjobs.yml#L584

@Kobzol

Kobzol commented Mar 13, 2025

Copy link
Copy Markdown
Member

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 13, 2025
@bors
Auto merge of rust-lang#128947 - Zoxc:thinlto-msvc, r=<try>
b9d7ae0 
Perform ThinLTO on x86_64-pc-windows-msvc dist builder

This reenables ThinLTO on x86_64-pc-windows-msvc.

Depends on rust-lang#122790

try-job: dist-x86_64-msvc
@bors

bors commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 3d3aba0 with merge b9d7ae0...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2025
@Kobzol

Kobzol commented Mar 13, 2025

Copy link
Copy Markdown
Member

@bors try

@bors

bors commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

⌛ Trying commit a832199 with merge 359c9af...

@Zoxc

Zoxc commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=jieyouxu

@rust-bors

rust-bors Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 9df405c has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 6, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 6, 2026
@bors
Auto merge of #128947 - Zoxc:thinlto-msvc, r=jieyouxu
69c0e54 
Perform ThinLTO on x86_64-pc-windows-msvc dist builder



This reenables ThinLTO on x86_64-pc-windows-msvc.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 6, 2026
@rust-bors

rust-bors Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 69c0e54 failed: CI. Failed job:

@JonathanBrouwer

JonathanBrouwer commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@bors retry

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2026
@JonathanBrouwer

JonathanBrouwer commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@bors p=6
Scheduling

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 6, 2026
@bors
Auto merge of #128947 - Zoxc:thinlto-msvc, r=jieyouxu
d031dae 
Perform ThinLTO on x86_64-pc-windows-msvc dist builder



This reenables ThinLTO on x86_64-pc-windows-msvc.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 6, 2026
@rust-bors

rust-bors Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

💔 Test for d031dae failed: CI. Failed job:

@JonathanBrouwer

JonathanBrouwer commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

^ Real failure
@bors r-

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 6, 2026
@rust-bors

rust-bors Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View changes since this unapproval

@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2026
@Zoxc

Zoxc commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@bors try

@rust-bors

rust-bors Bot commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⌛ Trying commit b6c55e1 with merge b3461f1…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/31143603897

rust-bors Bot pushed a commit that referenced this pull request Aug 7, 2026
@bors
Auto merge of #128947 - Zoxc:thinlto-msvc, r=<try>
b3461f1 
Perform ThinLTO on x86_64-pc-windows-msvc dist builder

try-job: dist-x86_64-apple
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Zoxc @rustbot @jieyouxu @lqd @bors @Kobzol @rust-log-analyzer @JonathanBrouwer @TaKO8Ki