dirfd dir operations (3/4) by Qelxiros · Pull Request #160533 · rust-lang/rust

Qelxiros · 2026-08-04T23:13:29Z

Previous PR: #150679
Reference: #139514
Tracking issue: #120426

rustbot · 2026-08-04T23:13:32Z

Any special-casing of Miri in the standard library requires review.

cc @rust-lang/miri

rustbot · 2026-08-04T23:13:35Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ChrisDenton, libs
@ChrisDenton, libs expanded to 13 candidates
Random selection from 6 candidates

Mark-Simulacrum

r=me with a few comments answered/nits addressed

View changes since this review

Mark-Simulacrum · 2026-08-08T22:59:31Z

+    ///
+    /// # Errors
+    ///
+    /// This function will return an error if `path` does not point to an existing directory.


I think we follow symlinks, right? Should we note that here?

We do follow them, but I don't think we need to note it. Dir::open and File::open (and maybe others) also follow symlinks without documenting that fact. If we decide that we should note it, that's a follow-up PR.

rustbot · 2026-08-08T23:00:31Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Qelxiros · 2026-08-09T03:34:57Z

@rustbot r=@Mark-Simulacrum

Qelxiros · 2026-08-09T03:36:17Z

@rustbot ready

Mark-Simulacrum · 2026-08-09T21:57:01Z

@bors r+

rust-bors · 2026-08-09T21:57:04Z

📌 Commit 354d65e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…crum dirfd dir operations (3/4) Previous PR: rust-lang#150679 Reference: rust-lang#139514 Tracking issue: rust-lang#120426

Rollup of 7 pull requests Successful merges: - #160533 (dirfd dir operations (3/4)) - #160675 (bootstrap: Remove `PATH_REMAP` from command-line selector handling ) - #160807 (Update rustc crate rkyv to 0.8.18) - #160560 (Add nightly-only support for Cargo unremap trim-paths files in `rust-gdb`) - #160804 (Change .expect message on net/parser to follow precondition style) - #160805 (`extern "custom"`: add tests) - #160816 (Mark const ptr methods and free functions as inline(always) to match *mut)

jhpratt · 2026-08-10T03:25:18Z

@bors r- #160823 (comment)

failures:

---- fs::tests::test_dir_create_dir stdout ----

thread 'fs::tests::test_dir_create_dir' (11204) panicked at library\std\src\fs\tests.rs:2753:5:
dir.create_dir("foo") failed with: creating or truncating a file requires write or append access
---- fs::tests::test_dir_create_dir stdout end ----
---- fs::tests::test_dir_open_dir stdout ----

thread 'fs::tests::test_dir_open_dir' (8216) panicked at library\std\src\fs\tests.rs:2761:5:
dir1.create_dir("foo") failed with: creating or truncating a file requires write or append access
---- fs::tests::test_dir_open_dir stdout end ----

failures:
    fs::tests::test_dir_create_dir
    fs::tests::test_dir_open_dir

test result: FAILED. 386 passed; 2 failed; 10 ignored; 0 measured; 0 filtered out; finished in 18.23s

error: test failed, to rerun pass `-p std --lib`
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src --skip=src/tools/linkchecker`
Currently active steps:
test::Crate { build_compiler: Compiler { stage: 2, host: aarch64-pc-windows-msvc, forced_compiler: false }, target: aarch64-pc-windows-msvc, mode: Std, crates: ["alloc", "alloctests", "compiler_builtins", "core", "coretests", "panic_abort", "panic_unwind", "proc_macro", "rustc-std-workspace-core", "std", "std_detect", "sysroot", "test", "unwind"] } at src\bootstrap\src\core\build_steps\test.rs:3378
Build completed unsuccessfully in 1:31:30
make: *** [Makefile:115: ci-msvc-py] Error 1
  local time: Mon Aug 10 03:17:26 CUT 2026
  network time: Mon, 10 Aug 2026 03:17:26 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

rust-bors · 2026-08-10T03:25:24Z

This pull request was unapproved.

This PR was contained in a rollup (#160823), which was unapproved.

View changes since this unapproval

asder8215 · 2026-08-10T15:14:10Z

@@ -87,6 +93,22 @@ impl Dir {
        self.rename_native(&from, to_dir, &to, is_dir)
    }

+    pub fn create_dir(&self, path: &Path) -> io::Result<()> {
+        let mut opts = OpenOptions::new();
+        opts.create_new(true);


this needs to be opts.read(true).write(true).create_new(true)

View changes since the review

I think it's preferable to chain this and write it as:

let opts = OpenOptions::new().read(true) .write(true) .create_new(true);

Qelxiros · 2026-08-12T01:18:25Z

@rustbot ready
I'd love a try job for the windows tests before this gets approved again.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 4, 2026

rustbot assigned Mark-Simulacrum Aug 4, 2026

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-dirs branch from 9815c2c to 11f3c91 Compare August 4, 2026 23:57

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-dirs branch from 11f3c91 to c69e7f2 Compare August 5, 2026 03:25

This comment has been minimized.

Sign in to view

RalfJung reviewed Aug 5, 2026

View reviewed changes

Comment thread library/std/src/sys/fs/unix/dir.rs Outdated

RalfJung reviewed Aug 5, 2026

View reviewed changes

Comment thread library/std/src/fs.rs

asder8215 reviewed Aug 5, 2026

View reviewed changes

Comment thread library/std/src/sys/fs/unix/dir.rs

Qelxiros force-pushed the dirfd-dirs branch from c69e7f2 to d0fd4d0 Compare August 5, 2026 23:57

Mark-Simulacrum requested changes Aug 8, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2026

Qelxiros force-pushed the dirfd-dirs branch from d0fd4d0 to 354d65e Compare August 9, 2026 03:31

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026

jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 9, 2026

Rollup merge of rust-lang#160533 - Qelxiros:dirfd-dirs, r=Mark-Simula…

7b6374c

…crum dirfd dir operations (3/4) Previous PR: rust-lang#150679 Reference: rust-lang#139514 Tracking issue: rust-lang#120426

jhpratt mentioned this pull request Aug 9, 2026

Rollup of 7 pull requests #160823

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 10, 2026

asder8215 reviewed Aug 10, 2026

View reviewed changes

add dir operations

4fc505d

Qelxiros force-pushed the dirfd-dirs branch from 354d65e to 4fc505d Compare August 12, 2026 01:15

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 12, 2026

Uh oh!

Uh oh!

Conversation

Qelxiros commented Aug 4, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 4, 2026

Uh oh!

rustbot commented Aug 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Mark-Simulacrum left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Mark-Simulacrum Aug 8, 2026

Choose a reason for hiding this comment

Uh oh!

Qelxiros Aug 9, 2026

Choose a reason for hiding this comment

Uh oh!

rustbot commented Aug 8, 2026

Uh oh!

Qelxiros commented Aug 9, 2026

Uh oh!

Qelxiros commented Aug 9, 2026

Uh oh!

Mark-Simulacrum commented Aug 9, 2026

Uh oh!

rust-bors Bot commented Aug 9, 2026

Uh oh!

jhpratt commented Aug 10, 2026

Uh oh!

rust-bors Bot commented Aug 10, 2026

Uh oh!

asder8215 Aug 10, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asder8215 Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

Qelxiros commented Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Qelxiros commented Aug 4, 2026 •

edited by rustbot

Loading

Mark-Simulacrum left a comment •

edited by rustbot

Loading

asder8215 Aug 10, 2026 •

edited by rustbot

Loading