fix ICE in `suggest_add_reference_to_arg` for non-callable items by im-lunex · Pull Request #160628 · rust-lang/rust

im-lunex · 2026-08-06T10:46:42Z

tcx.fn_sig(def_id) panicked ("unexpected sort of node in fn_sig()") when
the def_id in a WhereClauseInExpr obligation was the struct being
constructed, not the impl. This happens when a struct literal argument is
missing a field.

Guard both fn_sig call sites in suggest_add_reference_to_arg so the
suggestion only fires for callable defs.

Fixes #160591.

rustbot · 2026-08-06T10:46:46Z

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

JohnTitor

@bors r+

View changes since this review

rust-bors · 2026-08-06T22:14:20Z

📌 Commit 0d75b8c has been approved by JohnTitor

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 6. This pull request will be tested once the tree is reopened.

Reason for tree closure: Github problems

fix ICE in `suggest_add_reference_to_arg` for non-callable items `tcx.fn_sig(def_id)` panicked ("unexpected sort of node in fn_sig()") when the `def_id` in a `WhereClauseInExpr` obligation was the struct being constructed, not the impl. This happens when a struct literal argument is missing a field. Guard both `fn_sig` call sites in `suggest_add_reference_to_arg` so the suggestion only fires for callable defs. Fixes rust-lang#160591.

Kivooeo · 2026-08-07T01:07:45Z

hi, i want to ask it due to our new policy: was LLM used for this and if so how?

fix ICE in `suggest_add_reference_to_arg` for non-callable items `tcx.fn_sig(def_id)` panicked ("unexpected sort of node in fn_sig()") when the `def_id` in a `WhereClauseInExpr` obligation was the struct being constructed, not the impl. This happens when a struct literal argument is missing a field. Guard both `fn_sig` call sites in `suggest_add_reference_to_arg` so the suggestion only fires for callable defs. Fixes rust-lang#160591.

Rollup of 14 pull requests Successful merges: - #150885 (Revive L4Re target) - #159643 (Add support for splatted function pointers) - #160433 (delegation: add support for wrapping of the return value with `From::from`) - #160530 (refactor handling of target features in Session) - #160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`) - #160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items) - #160634 (miri subtree update) - #158904 (Fix FutureDropPoll shim for by-move async closures) - #160335 (dlopen offload) - #160445 (codegen: classify localized MSVC linker progress as linker_info) - #160504 (cleanup borrowck, improve c-variadic handling) - #160587 (Add regression test for associated type outlives bound at call site) - #160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.) - #160636 (derive(Diagnostic): link to proper docs)

im-lunex · 2026-08-07T04:23:22Z

@Kivooeo yeah used here for the text stuff tests/ui/structs/ice-missing-field-fn-sig.stderr used LLM for this file.

Kivooeo · 2026-08-07T04:53:59Z

you mean you used llm to generate .stderr file?

im-lunex · 2026-08-07T05:06:54Z

@Kivooeo yeah, 1st tried doing it by my self then saw there was typo mistakes and many more then used LLM on this .stderr file. LLM can be used in stderr type of files right ?

Kivooeo · 2026-08-07T05:08:32Z

we have --bless flag to generate .stderr files

./x test test-name --bless it will generate correct test-name.stderr

im-lunex · 2026-08-07T05:09:49Z

@Kivooeo nice im really new to this repo soo didn't knew that. thanks for you guidance

Kivooeo · 2026-08-07T05:11:46Z

It is highly encouraged to ask questions on Zulip.

im-lunex · 2026-08-07T05:15:25Z

It is highly encouraged to ask questions on Zulip.

yeah will try that out thanks for it. (btw i verified this with --bless and everything looks good tho)

Kivooeo · 2026-08-07T05:37:51Z

btw, @teor2345 do you have opinion on that fix?

fix ICE in `suggest_add_reference_to_arg` for non-callable items `tcx.fn_sig(def_id)` panicked ("unexpected sort of node in fn_sig()") when the `def_id` in a `WhereClauseInExpr` obligation was the struct being constructed, not the impl. This happens when a struct literal argument is missing a field. Guard both `fn_sig` call sites in `suggest_add_reference_to_arg` so the suggestion only fires for callable defs. Fixes rust-lang#160591.

…uwer Rollup of 21 pull requests Successful merges: - #159784 (Hint that memchr returns an in-bounds index) - #150885 (Revive L4Re target) - #159643 (Add support for splatted function pointers) - #160433 (delegation: add support for wrapping of the return value with `From::from`) - #160530 (refactor handling of target features in Session) - #160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`) - #160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items) - #160634 (miri subtree update) - #157641 (Do not promote extern statics) - #158904 (Fix FutureDropPoll shim for by-move async closures) - #160103 (Add regression test for GAT bound mismatched type error) - #160335 (dlopen offload) - #160445 (codegen: classify localized MSVC linker progress as linker_info) - #160499 (rustc_resolve: move diagnostic attribute linting to attr parsing) - #160504 (cleanup borrowck, improve c-variadic handling) - #160577 (expand: Feature gate AST-based attribute macros on expressions and statements) - #160587 (Add regression test for associated type outlives bound at call site) - #160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.) - #160636 (derive(Diagnostic): link to proper docs) - #160644 (Clean up some manual debug impls) - #160649 (move naked function ui tests)

fix ICE in `suggest_add_reference_to_arg` for non-callable items `tcx.fn_sig(def_id)` panicked ("unexpected sort of node in fn_sig()") when the `def_id` in a `WhereClauseInExpr` obligation was the struct being constructed, not the impl. This happens when a struct literal argument is missing a field. Guard both `fn_sig` call sites in `suggest_add_reference_to_arg` so the suggestion only fires for callable defs. Fixes rust-lang#160591.

…uwer Rollup of 20 pull requests Successful merges: - #159784 (Hint that memchr returns an in-bounds index) - #150885 (Revive L4Re target) - #159643 (Add support for splatted function pointers) - #160433 (delegation: add support for wrapping of the return value with `From::from`) - #160530 (refactor handling of target features in Session) - #160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`) - #160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items) - #160634 (miri subtree update) - #157641 (Do not promote extern statics) - #158904 (Fix FutureDropPoll shim for by-move async closures) - #160103 (Add regression test for GAT bound mismatched type error) - #160335 (dlopen offload) - #160445 (codegen: classify localized MSVC linker progress as linker_info) - #160499 (rustc_resolve: move diagnostic attribute linting to attr parsing) - #160504 (cleanup borrowck, improve c-variadic handling) - #160577 (expand: Feature gate AST-based attribute macros on expressions and statements) - #160587 (Add regression test for associated type outlives bound at call site) - #160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.) - #160636 (derive(Diagnostic): link to proper docs) - #160644 (Clean up some manual debug impls)

fix ICE in `suggest_add_reference_to_arg` for non-callable items `tcx.fn_sig(def_id)` panicked ("unexpected sort of node in fn_sig()") when the `def_id` in a `WhereClauseInExpr` obligation was the struct being constructed, not the impl. This happens when a struct literal argument is missing a field. Guard both `fn_sig` call sites in `suggest_add_reference_to_arg` so the suggestion only fires for callable defs. Fixes rust-lang#160591.

teor2345

This seems fine to merge, but it would be good to add some more test coverage soon.

As well as the impl case, it might also be worth adding a UI test for closures (if it's possible to construct one):

rust/compiler/rustc_hir/src/def.rs

Lines 367 to 372 in 65bcac4

    
           pub fn is_fn_like(self) -> bool { 
        
               matches!( 
        
                   self, 
        
                   DefKind::Fn | DefKind::AssocFn | DefKind::Closure | DefKind::SyntheticCoroutineBody 
        
               ) 
        
           }

View changes since this review

teor2345 · 2026-08-07T20:52:16Z

            c @ ObligationCauseCode::WhereClauseInExpr(def_id, _, hir_id, idx)
                if let hir::Node::Expr(expr) = self.tcx.hir_node(*hir_id)
                    && let hir::ExprKind::MethodCall(_segment, rcvr, args, ..) = expr.kind
+                    // The `def_id` can also point at the impl, which has no fn sig.


It would be good to have a test case for this change.
I think the current UI test only checks the struct case.

It's slightly odd that the method impl doesn't have a fn_sig, are you sure about that?
(This is a genuine question, because I don't know for sure.)

fix ICE in `suggest_add_reference_to_arg` for non-callable items `tcx.fn_sig(def_id)` panicked ("unexpected sort of node in fn_sig()") when the `def_id` in a `WhereClauseInExpr` obligation was the struct being constructed, not the impl. This happens when a struct literal argument is missing a field. Guard both `fn_sig` call sites in `suggest_add_reference_to_arg` so the suggestion only fires for callable defs. Fixes rust-lang#160591.

…uwer Rollup of 28 pull requests Successful merges: - #159784 (Hint that memchr returns an in-bounds index) - #160673 (Improve `canonical_param_env_cache`) - #150885 (Revive L4Re target) - #159643 (Add support for splatted function pointers) - #160433 (delegation: add support for wrapping of the return value with `From::from`) - #160530 (refactor handling of target features in Session) - #160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`) - #160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items) - #160683 (Add regression test for unknown feaeture name reported with other errors) - #157641 (Do not promote extern statics) - #158904 (Fix FutureDropPoll shim for by-move async closures) - #159816 (added note/help about iterator invalidation when mutating a collection inside a for loop) - #160103 (Add regression test for GAT bound mismatched type error) - #160335 (dlopen offload) - #160445 (codegen: classify localized MSVC linker progress as linker_info) - #160499 (rustc_resolve: move diagnostic attribute linting to attr parsing) - #160504 (cleanup borrowck, improve c-variadic handling) - #160577 (expand: Feature gate AST-based attribute macros on expressions and statements) - #160587 (Add regression test for associated type outlives bound at call site) - #160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.) - #160633 (delegation: fix determining wrong `FnKind` when delegation is inside const arg) - #160636 (derive(Diagnostic): link to proper docs) - #160644 (Clean up some manual debug impls) - #160649 (move naked function ui tests) - #160672 (Improve `MaybeLiveLocals`) - #160693 (Add branch config for perf. unrolling in bors) - #160696 (rustc_codegen_llvm: handle sm_101* features being an alias) - #160706 (renovate: clarify that vulnerability PRs are opened automatically)

fix ICE in suggest_add_reference_to_arg for non-callable items

0d75b8c

rustbot assigned JohnTitor Aug 6, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2026

JohnTitor approved these changes Aug 6, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2026

jhpratt mentioned this pull request Aug 7, 2026

Rollup of 14 pull requests #160661

Closed

jhpratt mentioned this pull request Aug 7, 2026

Rollup of 14 pull requests #160667

Closed

JonathanBrouwer mentioned this pull request Aug 7, 2026

Rollup of 21 pull requests #160678

Closed

JonathanBrouwer mentioned this pull request Aug 7, 2026

Rollup of 20 pull requests #160682

Closed

jhpratt mentioned this pull request Aug 7, 2026

Rollup of 30 pull requests #160721

Closed

teor2345 reviewed Aug 7, 2026

View reviewed changes

JonathanBrouwer mentioned this pull request Aug 7, 2026

Rollup of 28 pull requests #160725

Open

	pub fn is_fn_like(self) -> bool {
	matches!(
	self,
	DefKind::Fn \| DefKind::AssocFn \| DefKind::Closure \| DefKind::SyntheticCoroutineBody
	)
	}

Uh oh!

Uh oh!

Conversation

im-lunex commented Aug 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 6, 2026

Uh oh!

JohnTitor left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Aug 6, 2026

Uh oh!

Kivooeo commented Aug 7, 2026

Uh oh!

im-lunex commented Aug 7, 2026

Uh oh!

Kivooeo commented Aug 7, 2026

Uh oh!

im-lunex commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kivooeo commented Aug 7, 2026

Uh oh!

im-lunex commented Aug 7, 2026

Uh oh!

Kivooeo commented Aug 7, 2026

Uh oh!

im-lunex commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kivooeo commented Aug 7, 2026

Uh oh!

teor2345 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teor2345 Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

im-lunex commented Aug 6, 2026 •

edited by rustbot

Loading

JohnTitor left a comment •

edited by rustbot

Loading

im-lunex commented Aug 7, 2026 •

edited

Loading

im-lunex commented Aug 7, 2026 •

edited

Loading

teor2345 left a comment •

edited by rustbot

Loading