Stabilize bindings_after_at - #85305
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Alright, I think this is mostly okay, I'm uncertain on what I should do with E0303.md as it references the removed feature flag, it also is no longer used so I do not know procedure for updating it. I've left it untouched for now but I think it should probably be changed in some way even if it's just there for historical reasons at the moment. I also am unsure if making this stable means anything for the reference. To me the feature seems more or less implied by the reference currently, but I think an example of it would not go ammiss in the patterns section. I'm also aware that somewhere in here there's a stabilization report needed, I have no idea what that would look like as the examples I can find all have accosiated RFC's whereas |
This comment has been minimized.
This comment has been minimized.
|
r? @pnkfelix |
This comment has been minimized.
This comment has been minimized.
@MarcusDunn The reference is a submodule, it cannot actually be directly affected from here. You should |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #85458) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #85078) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #85734) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Because this is a language feature, #![cfg_attr(bootstrap, feature(bindings_after_at))] |
|
Stabilization report is here. |
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. The RFC will be merged soon. |
|
ping, shouldn't this be merged now? |
|
@bors r+ |
|
📌 Commit c2af4cb has been approved by |
|
☀️ Test successful - checks-actions |
attempting to stabilze bindings_after_at #65490, im pretty new to the whole thing so any pointers are greatly appreciated.