Skip to content

Stabilize bindings_after_at - #85305

Merged
bors merged 13 commits into
rust-lang:masterfrom
MarcusDunn:master
Jul 27, 2021
Merged

Stabilize bindings_after_at#85305
bors merged 13 commits into
rust-lang:masterfrom
MarcusDunn:master

Conversation

@MarcusDunn

@MarcusDunn MarcusDunn commented May 14, 2021

Copy link
Copy Markdown
Contributor

attempting to stabilze bindings_after_at #65490, im pretty new to the whole thing so any pointers are greatly appreciated.

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2021
@MarcusDunn MarcusDunn changed the title Add an entry for bindings_after_at to the unstable book [WIP] Stabilize bindings_after_at May 14, 2021
@MarcusDunn

MarcusDunn commented May 15, 2021

Copy link
Copy Markdown
Contributor Author

Alright, I think this is mostly okay, I'm uncertain on what I should do with E0303.md as it references the removed feature flag, it also is no longer used so I do not know procedure for updating it. I've left it untouched for now but I think it should probably be changed in some way even if it's just there for historical reasons at the moment. I also am unsure if making this stable means anything for the reference. To me the feature seems more or less implied by the reference currently, but I think an example of it would not go ammiss in the patterns section. I'm also aware that somewhere in here there's a stabilization report needed, I have no idea what that would look like as the examples I can find all have accosiated RFC's whereas bindings_after_at was removed prior to 1.0 and is now being added back in (afaik).

@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez

Copy link
Copy Markdown
Member

r? @pnkfelix

@rust-log-analyzer

This comment has been minimized.

@workingjubilee

workingjubilee commented May 16, 2021

Copy link
Copy Markdown
Member

Fetched in submodule path 'src/doc/reference', but it did not contain f2803ae48185e5c3d900ebd27b79976724570967. Direct fetching of that commit failed.

@MarcusDunn The reference is a submodule, it cannot actually be directly affected from here. You should git reset HEAD~1 --hard, force push that (this will remove the reference commit that is convincing CI the world is broken), and open another PR against rust-lang/reference in order to apply changes against it.

@MarcusDunn MarcusDunn changed the title [WIP] Stabilize bindings_after_at Stabilize bindings_after_at May 17, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors

bors commented May 19, 2021

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #85458) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented May 22, 2021

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #85078) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented May 27, 2021

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #85734) made this pull request unmergeable. Please resolve the merge conflicts.

@workingjubilee workingjubilee added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. T-lang Relevant to the language team labels Jun 3, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@workingjubilee

Copy link
Copy Markdown
Member

Because this is a language feature, /compiler/* and /library/* will require allowing the feature during bootstrap only, so that the bootstrap compiler opens the feature gates still while the next compiler stage does not.

#![cfg_attr(bootstrap, feature(bindings_after_at))]

@workingjubilee

Copy link
Copy Markdown
Member

Stabilization report is here.
Nominating for T-lang.

@rfcbot

rfcbot commented Jul 9, 2021

Copy link
Copy Markdown

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Jul 9, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 16, 2021
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 17, 2021
@programmerjake

Copy link
Copy Markdown
Member

ping, shouldn't this be merged now?

@pnkfelix

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jul 27, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit c2af4cb has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2021
@bors

bors commented Jul 27, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c2af4cb with merge 998cfe5...

@bors

bors commented Jul 27, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: pnkfelix
Pushing 998cfe5 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team

Projects

None yet

Development

Successfully merging this pull request may close these issues.