Fix ICE on libcall signature mismatch - #1688
Merged
Merged
Conversation
tgross35
reviewed
Aug 9, 2026
bjorn3
reviewed
Aug 11, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When code calls
f32.powi(),Cranelift lowers it to a libcall named__powisf2.If you also define your own#[no_mangle] fn __powisf2()with the wrong signature, backend tried to declare the symbol twice with different types and hit anunwrap(), which caused an internal compiler error instead of a normal error message.I fixed it by pulling the import declaration logic into a shared helper and using that for libcalls too,so signature conflicts now fail with a clear “attempt to declare __powisf2…” message like other function imports already do.
I also added a small repro in example/powi-libcall-signature.rs and a test to make sure this case errors cleanly and never ICEs again.
fixes: #1682