dist(release/1.29): backport patches, pt. 2#4927
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
rami3l
force-pushed
the
backport/202606
branch
4 times, most recently
from
2162e8c to
49f5332
Compare
rami3l
added
the
backport
Co-authored-by: rami3l <rami3l@outlook.com>
Co-authored-by: rami3l <rami3l@outlook.com>
Co-authored-by: rami3l <rami3l@outlook.com>
rami3l
force-pushed
the
backport/202606
branch
2 times, most recently
from
a07feb8 to
77c3359
Compare
Collaborator
|
This PR was rebased onto a different release/1.29 commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This prevents a random error on Linux when running the test on CI.
Sometimes, even after `fs::copy()` has returned, the executable is still
considered "busy" by the OS, causing the test to fail with:
```rust
Os { code: 26, kind: ExecutableFileBusy, message: "Text file busy" }
```
This change avoids that by using a direct arg0 override instead.
djc
approved these changes
Jun 30, 2026
djc
approved these changes
Jul 2, 2026
Member
Author
|
@djc Just to be sure, do you have more patches to merge before cutting the new release, or I can merge this and start drafting the changelog later this week? |
Contributor
I don't have any concrete plans, and I think the release would have been fine without including this refactoring stuff anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4862; continuation of #4867.