config: disable interrupts by default + document interrupt behavior of init() - #69
Merged
Merged
Conversation
phip1611
force-pushed
the
interrupts-fixes
branch
from
August 15, 2026 19:39
7b84b69 to
806b1bf
Compare
phip1611
marked this pull request as draft
August 15, 2026 19:39
phip1611
force-pushed
the
interrupts-fixes
branch
from
August 16, 2026 08:58
806b1bf to
c8d8aea
Compare
phip1611
marked this pull request as ready for review
August 16, 2026 09:00
phip1611
force-pushed
the
interrupts-fixes
branch
3 times, most recently
from
August 16, 2026 09:20
7d48aa0 to
744ac3f
Compare
Experience has shown that enabling interrupts by default can lead to surprising behavior during initialization, unless initialization is performed with CPU interrupts disabled [0]. Let's use a safer and simpler default. [0] rust-osdev/bootloader#565 (comment)
phip1611
force-pushed
the
interrupts-fixes
branch
from
August 16, 2026 10:50
744ac3f to
beef50d
Compare
- prevent that the function is raising interrupts - document interrupt behavior and recommendations
phip1611
force-pushed
the
interrupts-fixes
branch
2 times, most recently
from
August 16, 2026 10:57
959d1b6 to
f797136
Compare
In case a previous (incomplete) init sequence took place, this helps us to cleanly init the device.
phip1611
force-pushed
the
interrupts-fixes
branch
from
August 16, 2026 14:12
6d55032 to
6b314f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.