fix(ish): implement excludes for opendal source to some extent - #535
Open
hacker wants to merge 1 commit into
Open
fix(ish): implement excludes for opendal source to some extent#535hacker wants to merge 1 commit into
hacker wants to merge 1 commit into
Conversation
the new opendal as source backend supports no exclusion whatsoever, which is quite a shortcoming (and should probably be documented). This commit partially fixes that, it does not implement all exclusions, but at least it implements glob exclusions, which is better than nothing. I do not consider this commit a final resolution, especially given the general intention to get rid of dependency on `ignore`, but I'd say it's definitely an improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the new opendal as source backend supports no exclusion whatsoever, which is quite a shortcoming (and should probably be documented). This commit partially fixes that, it does not implement all exclusions, but at least it implements glob exclusions, which is better than nothing.
I do not consider this commit a final resolution, especially given the general intention to get rid of dependency on
ignore, but I'd say it's definitely an improvement.