Repository navigation
Runtime and card updates on cardvision 0.10.0 - #33
Merged
Merged
Conversation
From cfb8fb2 (cardvision 0.6.0rc2) to d0584b7 (cardvision 0.10.0). In between: release-load timings, the tilted retry (off unless a release asks for it), layout registration (not used by DuelSight), the session turning recognition off when the bundled release fails to load, and turned outlines (rotatedOutlines, off). OpenCV.js and ONNX Runtime Web 1.29.0 unchanged. No DuelSight code change was needed: the type check, lint and 576 tests pass; the store build has the same file list as 0.7.0; on Chrome for Testing 152 a dev build loads the live pointer release f3ed25290dde66e9 and names cards, and the Card language menu works as in 0.7.0. Signed-off-by: RDCLder <raymondyang.dev@gmail.com>
cdn/requirements.txt pins cardvision[cdn]==0.10.0. MAINTAINING.md (New cards, step 6) and cdn/SETTINGS.md give publish-release its refresh verdicts (--verdict-r, --verdict-n) or --no-refresh-gate with a reason, which 0.10.0 requires with --config. test/smoke/remote-smoke.mjs waits up to 2 minutes for the first analysis: with a pointer release to download and load, Chrome for Testing under Rosetta took 50 to 70 s, past the old 20 s. Signed-off-by: RDCLder <raymondyang.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves DuelSight from cardvision 0.6.0rc2 to 0.10.0.
Runtime (
vendor/cardvision-browser/): vendored from the 0.10.0 release commitd0584b7withscripts/vendor-runtime.mjs. OpenCV.js and ONNX Runtime Web 1.29.0 are unchanged. New in the runtime since 0.6.0rc2: release-load timings, the tilted retry (off unless a release asks for it), layout registration (not used here), recognition turning off when the bundled release fails to load, and turned outlines (rotatedOutlines, left off until 0.10.1 adds the outline to the shown card). DuelSight's own code needed no change.Card updates:
cdn/requirements.txtpinscardvision[cdn]==0.10.0.MAINTAINING.md(New cards, step 6) andcdn/SETTINGS.mdgivepublish-releasethe refresh verdicts (--verdict-r,--verdict-n) or--no-refresh-gatewith a reason, which 0.10.0 requires with--config.test/smoke/remote-smoke.mjswaits up to 2 minutes for the first analysis. With a pointer release to download and load, Chrome for Testing under Rosetta took 50 to 70 s, past the old 20 s; 0.7.0 failed the old wait the same way.Checked: type check, lint and 576 tests pass. The store build has the same file list as 0.7.0, and the Firefox build works. In Chrome for Testing 152 with a dev build, the live smoke test passes: it loads the live pointer release
f3ed25290dde66e9and names cards. The Card language menu switches the panel as in 0.7.0.No version change: this ships in the next store release, with turned outlines.