Repository navigation
Turned card outlines on cardvision 0.10.1 - #34
Merged
Merged
Conversation
Signed-off-by: RDCLder <raymondyang.dev@gmail.com>
The compute frame turns on the toolkit's rotatedOutlines (0.10.1): a turned card is hovered along its own edges, and the shown card carries its rotation, localWidth and localHeight. The outline draws that same shape (the card's sides about the center of its box, turned with CSS rotate), so it matches what the hover test uses. Upright cards, and any outline the parser drops, keep the upright box as before. Signed-off-by: RDCLder <raymondyang.dev@gmail.com>
Signed-off-by: RDCLder <raymondyang.dev@gmail.com>
ryangswe
added a commit
that referenced
this pull request
Nov 11, 2026
* Runtime: vendor cardvision-browser from toolkit 0.11.0 (fd0aa3c); card updates on cardvision 0.11.0 Signed-off-by: RDCLder <raymondyang.dev@gmail.com> * Compute frame: pace analysis from its measured cost Turns on the toolkit's measuredPacing (0.11.0): the wait between analyses follows what they cost on this computer (a quarter of the time at most), never faster than the fixed rates. A slow computer is no longer kept busy analyzing; on a fast one nothing changes. The toolkit's wait harness on DuelSight's dev clips, at an emulated 6x slower computer, showed shorter waits for the right name on every clip, the same cards answered, none wrong. Signed-off-by: RDCLder <raymondyang.dev@gmail.com> * Bundled release: 862aec0f937da326, the 2026-11-10 card update (f3ed25290dde66e9) converted to a binary bank Signed-off-by: RDCLder <raymondyang.dev@gmail.com> * Runtime: pin toolkit main 77dcac0 (0.11.0 plus the wait harness's cold-run fix; every vendored file unchanged) Signed-off-by: RDCLder <raymondyang.dev@gmail.com> * Version 0.8.0: turned card outlines and measured pacing Runtime: toolkit main 77dcac0 (cardvision 0.11.0's runtime). Bundled release 862aec0f937da326, the 2026-11-10 card update (f3ed25290dde66e9) converted to a binary bank. cdn/RUNTIMES.json gets its row, and docs/store-listing.md its version row. New since 0.7.0: a card lying at an angle is outlined and hovered along its own edges (#34), and analysis is paced from what it costs on the computer. Signed-off-by: RDCLder <raymondyang.dev@gmail.com> --------- Signed-off-by: RDCLder <raymondyang.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves DuelSight to cardvision 0.10.1 and outlines a card lying at an angle along its own edges. The extension's version doesn't change.
Runtime. The browser runtime is re-vendored from toolkit 0.10.1 (
8a0f2c2, tagv0.10.1). The worker is byte-identical to 0.10.0. Only the session, page-capture and compute-session files and their types changed: withrotatedOutlineson, the shown card carriesrotation,localWidthandlocalHeightwhen it is turned.Turned outlines. The compute frame turns on
rotatedOutlines, so a turned card responds to the pointer along its own edges, not its upright box. The outline draws that same shape: the card's sides around the center of its box, turned with CSSrotate(), matching the toolkit'scomputeCardQuad. Upright cards keep the box, as before, and so does any outline the message parser drops.Card updates.
cdn/requirements.txtpinscardvision[cdn]==0.10.1, which has the samepublish-releaseoptions as 0.10.0.Checks
npm test(581), typecheck, lint.