Skip to content

Lint: dropped background tasks, async mistakes, and unhandled promises in the viewer #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryangswe merged 1 commit into from
Nov 6, 2026
Merged

Lint: dropped background tasks, async mistakes, and unhandled promises in the viewer #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,4 @@ jobs:

- name: Lint viewer
working-directory: web
run: npx oxlint src
run: npx oxlint --type-aware src
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ timeline. It is the first of three planned tools; the programme is in `docs/road

- Install: `uv sync` and `cd web && npm ci`
- Lint: `uv run ruff check src tests && uv run ruff format --check src tests`;
viewer `cd web && npx oxlint src`
viewer `cd web && npx oxlint --type-aware src`
- Typecheck (viewer): `cd web && npx tsc -b`
- Test: `uv run pytest -q`. Real weights (about 1.3 GB download, then cached):
`JEPA_SCOPE_MODEL_TESTS=1 uv run pytest tests/test_real_model.py -s`
Expand Down
4 changes: 3 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ dev = [
line-length = 120

[tool.ruff.lint]
select = ["E", "F", "I", "B", "UP"]
select = ["E", "F", "I", "B", "UP", "PLE", "ASYNC", "RUF006"]
# ASYNC rules that give advice rather than find bugs.
ignore = ["ASYNC109", "ASYNC110", "ASYNC115", "ASYNC116"]

[tool.pytest.ini_options]
testpaths = ["tests"]
6 changes: 5 additions & 1 deletion web/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
"plugins": ["react", "typescript", "oxc"],
"rules": {
"react/rules-of-hooks": "error",
"react/only-export-components": ["warn", { "allowConstantExport": true }]
"react/only-export-components": ["warn", { "allowConstantExport": true }],
"typescript/no-floating-promises": "error",
"typescript/no-misused-promises": "error",
"typescript/await-thenable": "error",
"typescript/switch-exhaustiveness-check": ["error", { "considerDefaultExhaustiveForUnions": true }]
}
}
107 changes: 105 additions & 2 deletions web/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"scripts": {
"dev": "vite",
"build": "tsc -b && vite build",
"lint": "oxlint",
"lint": "oxlint --type-aware",
"preview": "vite preview"
},
"dependencies": {
Expand All @@ -19,6 +19,7 @@
"@types/react-dom": "^19.3.0",
"@vitejs/plugin-react": "^6.1.2",
"oxlint": "^1.90.0",
"oxlint-tsgolint": "7.0.2006",
"typescript": "~7.0.2",
"vite": "^8.3.6"
}
Expand Down
Loading