Skip to content

Fix: handle sms: and tel: links and support regular navigations #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Coleton (Locrian24) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: handle sms: and tel: links and support regular navigations #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45d5a4a
fix: handle sms: and tel: links and support all external schemes on r…
Locrian24 Apr 2, 2026
b6ceb67
fix: restore external scheme handling in createWebViewWith for target…
Locrian24 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions Sources/SaaSquatchWebView/SaaSquatchWebView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import SwiftyJSON
import WebKit
import SaaSquatch

public class SaaSquatchWebView: WKWebView, WKUIDelegate {
public class SaaSquatchWebView: WKWebView, WKUIDelegate, WKNavigationDelegate {
public var client: SaaSquatchClient?

/**
Expand Down Expand Up @@ -86,9 +86,12 @@ public class SaaSquatchWebView: WKWebView, WKUIDelegate {
}
}

private static let externalSchemes: Set<String> = ["mailto", "sms", "tel"]

private func setWebViewContent(html: String) {
DispatchQueue.main.async {
self.uiDelegate = self
self.navigationDelegate = self
let htmlWithMeta = html.replacingOccurrences(of: "</head>", with: "<meta name=\"viewport\" content=\"initial-scale=1.0\" /></head>")
self.loadHTMLString(htmlWithMeta, baseURL: URL(string: "https://fast.ssqt.io"))
}
Expand Down Expand Up @@ -124,12 +127,26 @@ public class SaaSquatchWebView: WKWebView, WKUIDelegate {
for navigationAction: WKNavigationAction,
windowFeatures: WKWindowFeatures) -> WKWebView? {
if let url = navigationAction.request.url, navigationAction.targetFrame == nil {
if url.scheme == "http" || url.scheme == "https" || url.scheme == "mailto" {
if url.scheme == "http" || url.scheme == "https"
|| Self.externalSchemes.contains(url.scheme ?? "") {
UIApplication.shared.open(url)
}
}
return nil
}

public func webView(_ webView: WKWebView,
decidePolicyFor navigationAction: WKNavigationAction,
decisionHandler: @escaping (WKNavigationActionPolicy) -> Void) {
if let url = navigationAction.request.url,
let scheme = url.scheme,
Self.externalSchemes.contains(scheme) {
UIApplication.shared.open(url)
Comment on lines +141 to +144

Copilot AI Apr 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL.scheme is case-insensitive by spec, but the externalSchemes lookup is currently case-sensitive. This can fail to intercept links like TEL:/MailTo: coming from HTML. Consider normalizing the scheme (e.g., compare scheme.lowercased() against the set) before checking membership.

Copilot uses AI. Check for mistakes.
decisionHandler(.cancel)
return
}
decisionHandler(.allow)
}
}

let ERROR_HTML_TEMPLATE = """
Expand Down
Loading