Repository navigation
Conversation
plv1313
changed the title
Author
|
@alexcrichton would love your feedback on that |
Collaborator
|
Sorry, but I do not have the bandwidth/time to review major new features to this crate like this. |
Author
|
@alexcrichton no worries thanks for the reply. Maybe @sagebind if you have time. |
plv1313
force-pushed
the
feat/c-ares-static-curl
branch
from
October 26, 2026 20:37
9c6871f to
75aacb2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
c-aresfeature and wires it through both crates.Included changes:
c-aresfeature incurlandcurl-sys.static-curl + c-ares).pkg-configon non-Windowsvcpkgon MSVCc-areswithoutstatic-curlrequire a system libcurl that was built with c-ares (explicit failure otherwise).c-aresbehavior and requirements.