refactor: improve Lua types - #28
Merged
Merged
Conversation
soifou
force-pushed
the
refactor/improve-annotations
branch
from
July 31, 2026 17:32
4258db8 to
8ff005b
Compare
soifou
force-pushed
the
refactor/improve-annotations
branch
from
August 8, 2026 11:09
8ff005b to
35c7fde
Compare
Owner
|
LGTM, any blockers to merging? |
soifou
force-pushed
the
refactor/improve-annotations
branch
from
September 5, 2026 10:18
35c7fde to
8a3f98f
Compare
soifou
force-pushed
the
refactor/improve-annotations
branch
from
September 5, 2026 10:18
8a3f98f to
127ca85
Compare
soifou
marked this pull request as ready for review
September 5, 2026 10:20
Collaborator
Author
|
Nope, safe to merge! I was thinking of doing another pass, but holidays and all 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly the same kind of cleanup as the recent blink.cmp changes: improve annotations, fix inaccurate types, and address analyzer warnings while keeping runtime behavior unchanged.