Repository navigation
Conversation
ajdunker
force-pushed
the
feat/search-workflow-indices
branch
3 times, most recently
from
October 22, 2026 22:17
963e352 to
c97997d
Compare
Author
Live test resultsBuilt from
Notes:
|
ajdunker
force-pushed
the
feat/search-workflow-indices
branch
2 times, most recently
from
October 22, 2026 22:31
c97997d to
ad609b4
Compare
ajdunker
force-pushed
the
feat/search-workflow-indices
branch
from
October 22, 2026 22:31
ad609b4 to
c87f2c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds support for the
workflowsummariesandworkflowexecutionsindices tosail search query, fixing #267.ParseIndicesnow acceptsworkflowsummariesandworkflowexecutions. The golang-sdksearch.Indextype is a plain string (its generated comment notes "Additional values may be added in the future without notice"), so these are handled with direct casts until the SDK enum gains constants. Unknown indices still fail fast locally withindex provided is invalid.WorkflowSummaryandWorkflowExecutionresult types (per the searchable workflow history fields: step events withworkflowExecutionId,eventId,stepName/task/input/result/errorunder a permissiveattributesmap; executions withstatus,startTime,closeTime,requestId,failureType,failureMessage,owner, andtrigger)._typedispatch forworkflowsummary/workflowexecutionadded to bothPerformSearchandPerformSearchWithLimit, so results are decoded instead of silently dropped.IterateIndicessaves the new result sets alongside the existing six.--indicesflag help lists all eight valid values.Why
Closes #267 — workflow history is searchable in these two indices but the CLI rejected them, leaving
sail api post /v2025/searchas the only workaround (which skips CLI paging and result handling).Validation
go build ./...— cleango vet ./internal/search/... ./cmd/search/...— cleango test -count=1 ./cmd/search/...— existing tests passsail search queryagainst a tenant with--indices workflowsummariesand--indices workflowexecutionssaves decoded results with all fields populated, including mixed with--indices roles