Reject unsupported schematic properties without stopping the Altium bridge - #35
Closed
TerrenceHenry wants to merge 2 commits into
Closed
TerrenceHenry wants to merge 2 commits into
TerrenceHenry wants to merge 2 commits into
Conversation
Owner
|
Thanks, this is a good fix. Tested on AD 26.10.1.6: both cases from #34 reproduce there, and |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Altium 21, creating an eNetLabel with IsHidden or querying an eParameterSet's Text opened an undeclared-identifier dialog and stopped bridge polling. Guard both reads and writes before member access. Reject unsupported create items before registration, dispose of the temporary object, and report the property/type while allowing valid batch items to continue.
Closes #34. Related to the already-closed #22.
The change preserves tool inputs and supported property paths. Batch failures add a property field with reason UNSUPPORTED_PROPERTY. It follows the existing narrow capability guards rather than introducing a complete property registry. No customer design is included in the patch.
Type and areas
Validation
Review notes
Live Altium acceptance is complete. Keep this PR in draft while upstream CI/FPC execution is gated by action_required. Restart Altium after installing candidate scripts: it caches Pascal scripts. The disposable-schematic procedure is in docs/RELEASE_VERIFICATION.md and includes object counts, invalid/valid mixed batches, and ping/query continuity after rejection.
Commits use plain imperative subjects per CONTRIBUTING.md (the template's conventional-commit checkbox is stale). No secrets, customer designs, proprietary library paths, generated bundles or version bump are included. Stale compiled connectivity remains out of scope.
Validation note: for future acceptance runs, close unrelated design documents or retain byte-for-byte backups first. Save-all can rewrite already-clean open sheets; it is not a preservation check.