Guard schematic TextColor access without stopping Altium polling - #38
Closed
TerrenceHenry wants to merge 1 commit into
Closed
TerrenceHenry wants to merge 1 commit into
TerrenceHenry wants to merge 1 commit into
Conversation
TerrenceHenry
marked this pull request as ready for review
October 3, 2026 19:17
Owner
|
Thanks Terrence, merged as 4c2e274 with your authorship. I resolved the conflicts with the latest main and bumped the script to 2026.10.05.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Querying
TextColoron a schematic power object raised anUndeclared identifier: TextColormodal on Altium 21.4.1.30 and stopped polling. The getter, setter, filters and creation paths could reach the same unsupported member.Allow TextColor only on the documented port, sheet-entry and harness-entry interfaces, and access it through typed locals. Unsupported query fields remain empty with unreadable diagnostics; project queries now include those diagnostics too. Filters refuse known unsupported properties before comparison, so
TextColor=cannot match an unreadable value. Modification preflights the complete assignment list before moving or recolouring an object; creation uses the existing single refusal and indexed batch-failure format. Independent valid batch items continue.The assignment preflight also protects the already-guarded Text/IsHidden pairs. It does not make arbitrary writes transactional or claim a complete property capability map. Script version is bumped to 2026.10.03.1; reload the script project or restart Altium before acceptance.
Closes #37.
Validation:
Limits and related observation: harness-entry round trips were not performed because the generic object-type mapping does not expose that owner and no fixture was available; its owner guard is covered by the compiler job. Existing batch-modify diagnostics are cumulative: a later valid item inherits a failure note although its write readback passes. This reporting issue is outside the TextColor crash fix. Upstream CI and the live acceptance cases above are complete.