Skip to content

Clear cancelled Aiden Live picker state before 0.41.4 - #136

Merged
sambitcreate merged 2 commits into
mainfrom
feature/aiden-live-0.41.4-picker-busy-fix
Sep 17, 2026
Merged

sambitcreate merged 2 commits into
mainfrom
feature/aiden-live-0.41.4-picker-busy-fix

Conversation

@sambitcreate

Copy link
Copy Markdown
Owner

Summary

  • block Live start while the native screen picker is pending
  • clear the picker busy state whenever display authority is cancelled
  • keep stale picker completions from clearing a newer operation
  • add controller and setup-dialog regression coverage

Validation

  • npm run type-check
  • npm run lint
  • npm run test:gemini-live (180 Live + 48 Computer Use)

Release coordination

The 0.41.4 release run from #135 was cancelled before publication when Pullfrog posted this final inline finding. Merge only after exact-head CI, Pullfrog, and a fresh unresolved-thread query are all clean.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

This PR can leave the Live setup permanently unable to start screen picking after a capability or API refresh during an in-flight picker.

Reviewed changes This review covers the setup-dialog start guard, picker-generation cancellation reset, and the focused controller/UI regression coverage plus release documentation.

  • Picker gating Start Live and the controller now refuse to begin while the native display picker is pending.
  • Cancellation handling Display-authority invalidation resets the picker busy state and preserves late-picker fencing.
  • Regression coverage The tests cover pending-picker start blocking, synchronous cancellation reset, late stream cleanup, and the setup-dialog contract.

Pullfrog  | Fix all ➔Fix 👍s ➔View workflow run | Using GPT Luna𝕏

Comment thread renderer/components/assistant/use-assistant-live.ts

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes This incremental review covers the picker re-arm follow-up pushed since the prior Pullfrog review.

  • Re-armed picker state Reset screenBusy from the replacement lifecycle effect after API or capability cleanup, while preserving the final-unmount guard.
  • Added refresh regression coverage Added an API-refresh fixture path that proves a cancelled native picker can be followed by a new screen choice.
  • Recorded the lifecycle lesson Documented the React effect cleanup and replacement-setup sequencing in the troubleshooting notes.

Pullfrog  | View workflow run | Using GPT Luna𝕏

@sambitcreate
sambitcreate merged commit 2b7108a into main Sep 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant