Clear cancelled Aiden Live picker state before 0.41.4 - #136
Merged
Merged
Conversation
There was a problem hiding this comment.
Important
This PR can leave the Live setup permanently unable to start screen picking after a capability or API refresh during an in-flight picker.
Reviewed changes This review covers the setup-dialog start guard, picker-generation cancellation reset, and the focused controller/UI regression coverage plus release documentation.
- Picker gating
Start Liveand the controller now refuse to begin while the native display picker is pending. - Cancellation handling Display-authority invalidation resets the picker busy state and preserves late-picker fencing.
- Regression coverage The tests cover pending-picker start blocking, synchronous cancellation reset, late stream cleanup, and the setup-dialog contract.
GPT Luna | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes This incremental review covers the picker re-arm follow-up pushed since the prior Pullfrog review.
- Re-armed picker state Reset
screenBusyfrom the replacement lifecycle effect after API or capability cleanup, while preserving the final-unmount guard. - Added refresh regression coverage Added an API-refresh fixture path that proves a cancelled native picker can be followed by a new screen choice.
- Recorded the lifecycle lesson Documented the React effect cleanup and replacement-setup sequencing in the troubleshooting notes.
GPT Luna | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Validation
npm run type-checknpm run lintnpm run test:gemini-live(180 Live + 48 Computer Use)Release coordination
The 0.41.4 release run from #135 was cancelled before publication when Pullfrog posted this final inline finding. Merge only after exact-head CI, Pullfrog, and a fresh unresolved-thread query are all clean.